Commit f54110fd authored by Tim-Philipp Müller's avatar Tim-Philipp Müller 🐠

udp: don't use soon-to-be-deprecated g_cancellable_reset()

From the API documentation: "Note that it is generally not
a good idea to reuse an existing cancellable for more
operations after it has been cancelled once, as this
function might tempt you to do. The recommended practice
is to drop the reference to a cancellable after cancelling
it, and let it die with the outstanding async operations.
You should create a fresh cancellable for further async
operations."

https://bugzilla.gnome.org/show_bug.cgi?id=739132
parent 168881a1
......@@ -574,7 +574,8 @@ gst_dynudpsink_unlock_stop (GstBaseSink * bsink)
udpsink = GST_DYNUDPSINK (bsink);
g_cancellable_reset (udpsink->cancellable);
g_object_unref (udpsink->cancellable);
udpsink->cancellable = g_cancellable_new ();
return TRUE;
}
......@@ -1845,7 +1845,8 @@ gst_multiudpsink_unlock_stop (GstBaseSink * bsink)
sink = GST_MULTIUDPSINK (bsink);
g_cancellable_reset (sink->cancellable);
g_object_unref (sink->cancellable);
sink->cancellable = g_cancellable_new ();
return TRUE;
}
......@@ -1139,7 +1139,8 @@ gst_udpsrc_unlock_stop (GstBaseSrc * bsrc)
src = GST_UDPSRC (bsrc);
GST_LOG_OBJECT (src, "No longer flushing");
g_cancellable_reset (src->cancellable);
g_object_unref (src->cancellable);
src->cancellable = g_cancellable_new ();
return TRUE;
}
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment