Commit 0c9b039c authored by Tim-Philipp Müller's avatar Tim-Philipp Müller 🐠

pulsesink: don't error out if pa_stream_proplist_update() with new tags fails

Shouldn't really happen these days, but if it does, it's not really
a problem either.

https://bugzilla.gnome.org/show_bug.cgi?id=656068
parent 066600c1
......@@ -2700,11 +2700,12 @@ gst_pulsesink_change_props (GstPulseSink * psink, GstTagList * l)
if (pbuf == NULL || pbuf->stream == NULL)
goto no_buffer;
/* We're not interested if this operation failed or not */
if (!(o = pa_stream_proplist_update (pbuf->stream, PA_UPDATE_REPLACE,
pl, NULL, NULL)))
goto update_failed;
pl, NULL, NULL))) {
GST_DEBUG_OBJECT (psink, "pa_stream_proplist_update() failed");
}
/* We're not interested if this operation failed or not */
unlock:
if (o)
......@@ -2725,13 +2726,6 @@ no_buffer:
GST_DEBUG_OBJECT (psink, "we have no ringbuffer");
goto unlock;
}
update_failed:
{
GST_ELEMENT_ERROR (psink, RESOURCE, FAILED,
("pa_stream_proplist_update() failed: %s",
pa_strerror (pa_context_errno (pbuf->context))), (NULL));
goto unlock;
}
}
static void
......
Markdown is supported
0% or .
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment