Commit cb9799e9 authored by Jan Schmidt's avatar Jan Schmidt Committed by GStreamer Marge Bot

video-converter: Skip input lines where possible.

There is a case where there are no lines in the temp cache, and
it's possible to skip straight to the request line and not generate
intermediate ones. This is really only beneficial when doing
nearest-neighbour downscaling, as other methods generally require
all input lines sequentially to generate the output. In that case,
this change has no effect and all lines are generated and cached
as before.

As a side effect however, this fixes corruption when downscaling
using nearest-neighbour, as interactions with the pass_alloc flag
and reuse of temporary lines causes the unecessarily-generated
cache lines to overwrite the final output.

Part-of: <gstreamer/gst-plugins-base!919>
parent f51b3fcd
......@@ -612,6 +612,10 @@ gst_line_cache_get_lines (GstLineCache * cache, gint idx, gint out_line,
if (cache->need_line == NULL)
/* We may be able to skip ahead to the earliest line needed */
if (cache->lines->len == 0 && cache->first + cache->backlog < in_line)
cache->first = in_line - cache->backlog;
oline = out_line + cache->first + cache->lines->len - in_line;
if (!cache->need_line (cache, idx, oline, cache->first + cache->lines->len,
Markdown is supported
0% or .
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment