Commit 23d1440a authored by Edward Hervey's avatar Edward Hervey 🤘 Committed by Edward Hervey

urisourcebin: Avoid potential unitialized/wrong bitrate value

Only calculate and set the bitrate if all conditions are met.
parent 18942d78
......@@ -1003,15 +1003,13 @@ update_queue_values (GstURISourceBin * urisrc)
for (cur = urisrc->out_slots; cur != NULL; cur = g_slist_next (cur)) {
OutputSlotInfo *slot = (OutputSlotInfo *) (cur->data);
guint64 bitrate;
guint byte_limit;
if (cumulative_bitrate > 0) {
if (g_object_class_find_property (G_OBJECT_GET_CLASS (slot->queue),
"bitrate")) {
g_object_get (G_OBJECT (slot->queue), "bitrate", &bitrate, NULL);
if (cumulative_bitrate > 0
&& g_object_class_find_property (G_OBJECT_GET_CLASS (slot->queue),
"bitrate")) {
guint64 bitrate;
g_object_get (G_OBJECT (slot->queue), "bitrate", &bitrate, NULL);
byte_limit =
gst_util_uint64_scale (buffer_size, bitrate, cumulative_bitrate);
} else {
Markdown is supported
0% or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment