Commit 02339bd8 authored by Thibault Saunier's avatar Thibault Saunier 🌵 Committed by GStreamer Marge Bot

validate: Fix marking expected issues as criticals

And never mark a repeat expected reports as repeated

Part-of: <gstreamer/gst-devtools!207>
parent b23cb623
......@@ -218,7 +218,7 @@ gst_validate_report_valist (GstValidateReporter * reporter,
prev_report = g_hash_table_lookup (priv->reports, (gconstpointer) issue_id);
runner = gst_validate_reporter_get_runner (reporter);
if (prev_report) {
if (prev_report && prev_report->level != GST_VALIDATE_REPORT_LEVEL_EXPECTED) {
GstValidateReportingDetails reporter_level =
gst_validate_reporter_get_reporting_level (reporter);
GstValidateReportingDetails runner_level = GST_VALIDATE_SHOW_UNKNOWN;
......
......@@ -688,8 +688,10 @@ gst_validate_runner_add_report (GstValidateRunner * runner,
if (report->level == GST_VALIDATE_REPORT_LEVEL_IGNORE)
return;
if (check_report_expected (runner, report))
if (check_report_expected (runner, report)) {
GST_INFO_OBJECT (runner, "Found expected issue: %p", report);
report->level = GST_VALIDATE_REPORT_LEVEL_EXPECTED;
}
gst_validate_send (json_boxed_serialize (GST_MINI_OBJECT_TYPE (report),
report));
......@@ -824,7 +826,8 @@ _do_report_synthesis (GstValidateRunner * runner)
if ((report->level == GST_VALIDATE_REPORT_LEVEL_CRITICAL) ||
(report->issue->flags & GST_VALIDATE_ISSUE_FLAGS_FULL_DETAILS)) {
criticals = g_list_append (criticals, report);
if (report->level == GST_VALIDATE_REPORT_LEVEL_CRITICAL)
criticals = g_list_append (criticals, report);
gst_validate_report_print_details (report);
}
}
......
Markdown is supported
0% or .
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment