- Mar 21, 2019
-
-
Remove unused code related to GUdevDevice. Signed-off-by:
Yuri Benditovich <yuri.benditovich@daynix.com> Acked-by:
Christophe Fergeau <cfergeau@redhat.com>
-
Unify SpiceUsbDeviceInfo for Linux and Windows by using persistent libusb_device. Probably there was some problem doing it long time ago with winusb, but at least with existing libusb and UsbDk the the libusb device can be accessed as long as it is referenced. Signed-off-by:
-
Change the signal to report libusb_device instead of GUdevDevice object. This simplifies the callback procedure in usb-dev-manager and avoids additional reenumeration immediately after reenumeration that already done by win-usb-dev. Signed-off-by:
-
Christophe Fergeau authored
-
Change internal device list to maintain libusb devices instead of GUdevDevice objects. Create temporary GUdevDevice object only for indication to usb-dev-manager. Signed-off-by:
-
When processing list of USB devices, avoid allocating memory for devices which later will be skipped. Use existing libusb struct first to check whether the device shall be excluded. Signed-off-by:
-
Changing signal definition from (boxed-boxed) to (pointer,int). There is no need for additional referencing of GUdevDevice object before signal callback. Second parameter (action) is FALSE for device removal and TRUE for device addition. Signed-off-by:
-
Discard the optimization of initial device enumeration. Just after connection to the 'uevent' signal, request to report all the devices one by one as if they are inserted. Further commits will remove device enumeration in usb-dev-manager completely. Signed-off-by:
-
Remove unused g_udev_device_get_sysfs_attr. Signed-off-by:
-
If when calling handle_dev_change, the new device has the same bus:address as an existing device cached in GUdevClient::udev_list, then an "uevent" signal will not be emitted to notify about the new device. For example, when due to some reason the 'redirecting' property is set for a long time and during this time one device is unplugged and then replugged. This commit makes the device comparison more strict by checking not only bus:addr, but also vid:pid. Signed-off-by:
-
In initial device enumeration, hotplug notification can be called twice with the same libusb device. For details, see http://libusb.sourceforge.net/api-1.0/group__libusb__hotplug.html#ga00e0c69ddf1fb1b6774dc918192e8dc7 This commit filters out devices that are already present in the list. It also removes the identical call in spice_usb_device_manager_add_udev, which adds devices under Windows. Signed-off-by:
-
Do not create our own libusb context in usb-device-manager. Reuse existing context created by win-usb-dev instead, this will later allow usb-device-manager to use libusb devices enumerated in win-usb-dev. Signed-off-by:
-
Removing unused parameter from GUdevClient constructor. This code is used only in Windows builds. Signed-off-by:
-
Replacing USE_GUDEV with G_OS_WIN32 anywhere. GUDEV simulation is used only in Windows build. Signed-off-by:
-
- Mar 19, 2019
-
-
Christophe Fergeau authored
spice-server does not deal properly with multiple smartcard readers, only the first one will be working. Add a warning when this happens to make it easier to diagnose such issues. Signed-off-by:
Marc-André Lureau <marcandre.lureau@gmail.com>
-
- Mar 18, 2019
-
-
Victor Toso authoredWe already require libusb 1.0.16 or above since 8269a5be (build-sys: drop support for libusb < 1.0.16) Signed-off-by:
Victor Toso <victortoso@redhat.com> Acked-by:
-
Victor Toso authored
usbredir-0.7.1 was released on 29-Oct-2015, relatively old compared to most recent usbredir-0.8.0 from 03-Aug-2018. * Debian 9 (stretch) -> 0.7.1 * Fedora 21 to Fedora 27 -> 0.7.1 * Fedora 28 to rawhide -> 0.8.0 Signed-off-by:
-
- Mar 08, 2019
-
-
Victor Toso authored
As this is NOP from previous patch and has been deprecated since v0.34 Signed-off-by:
-
Victor Toso authored
With commit 1a980f37 we deprecated some command line options. The color-depth one is the only one which is not used for testing/debug purposes. The intention of this option is to set guest's video driver color configuration, currently only windows guest agent uses this feature up to Windows 7. Windows 8 and up, setting color depth below 32 would fail. We should not encourage the usage of this feature. Related: https://bugzilla.redhat.com/show_bug.cgi?id=1543538 Related: https://bugzilla.redhat.com/show_bug.cgi?id=1350853 This patch deprecates both SpiceMainChannel::color-depth and SpiceSession::color-depth while ignoring any set/get to it. Signed-off-by:
-
- Mar 01, 2019
-
-
This is not necessary, as meson already checks out the git submodules. Signed-off-by:
Marc-André Lureau <marcandre.lureau@redhat.com> Acked-by:
Frediano Ziglio <fziglio@redhat.com>
-
- Feb 22, 2019
-
-
Victor Toso authored
Documentation for gdk_display_get_primary_monitor() says that it returns "the primary monitor, or NULL if no primary monitor is configured by the user". If monitor end up being NULL, we end up using uninitialized GdkRectangle geom later on as gdk_monitor_get_geometry() will fail with: | gdk_monitor_get_geometry: assertion 'GDK_IS_MONITOR (monitor)' failed This patch tries gdk_display_get_monitor_at_point() and will fail if no GdkMonitor is set. Signed-off-by:
-
Currently we set timestamps as buffer's PTS, this value may be changed by the pipeline in some cases and cause an unexpected buffer warnings (when GstVideoOverlay is not used). Use GstReferenceTimestampMeta when synchronization is made by spice. Before applying this patch you can reproduce the warnings by runing with DISABLE_GSTVIDEOOVERLAY=1 and starting some audio playback in the guest. Signed-off-by:
Snir Sheriber <ssheribe@redhat.com> Acked-by:
-
Olivier Fourdan authored
The Spice Gtk widget relies on pointer grabs to receive all pointer events even after the pointer has left the window. While that works on X11, on Wayland there is no active pointer grab, so once the pointer has left the SPICE widget on Wayland, the events are routed to the window with the pointer focus instead of ours. To avoid the problem, on Wayland, we simply ungrab the pointer once it leaves the window. Thanks-to: Peter Hutterer <peter.hutterer@who-t.net> Signed-off-by:
Olivier Fourdan <ofourdan@redhat.com> spice/spice-gtk#83 Acked-by:
-
Olivier Fourdan authored
Using different GDK APIs to grab and ungrab devices leads to undetermined behavior and can cause the cursor to remain hidden on ungrab on Wayland because GDK Wayland backend keeps a reference of the GdkSeat cursor. On Wayland, use the GdkSeat API only even for ungrab, by ungrabbing the seat and immediately re-grabbing the remaining keyboard or pointer if the grab is to be retained. Thanks-to: Peter Hutterer <peter.hutterer@who-t.net> Signed-off-by:
-
- Feb 21, 2019
-
-
Frediano Ziglio authored
Allows the compiler to catch some errors which are only triggered when building with optimizations enabled. Signed-off-by:
Jonathon Jongsma <jjongsma@redhat.com>
-
Frediano Ziglio authored
Commit 9cf6d39b369f9c22615fc329e307126721125ecd ("server,proto: tell the clients to connect to the migration target before migraton starts", dated 18th September 2011) removed these fields. Avoid to use them. If nobody complained in more than 7 years it means this path of the code is not used. Signed-off-by:
-
- Feb 19, 2019
-
-
Frediano Ziglio authored
As autoconf provide e-mail address in the .po files. The change in main meson.build is just a move to allow the other meson.buuild to see the setting. Signed-off-by:
-
Frediano Ziglio authored
Allows to handle these statistics in a more flexible way. Signed-off-by:
-
Frediano Ziglio authored
recorder library will be used to collect some statistics during development. Signed-off-by:
-
- Feb 18, 2019
-
-
Follow meson build system conventions. This will allow meson to handle it as a subproject. Signed-off-by:
-
- Feb 15, 2019
-
-
Frediano Ziglio authored
This causes a critical warning as private structures should not be empty. Signed-off-by:
-
Use glib preset (from meson v0.37) to catch all our translatable strings and use good default settings. While at it, remove the needless directory argument. Signed-off-by:
-
- Feb 14, 2019
-
-
Victor Toso authored
To keep track of meson builds for windows too. Note that mingw64-meson requires to be ran inside the folder, different from common meson. So, some extra steps were done due that. v1 -> v2: - Remove initial '_' from build folder filenames (Frediano); - Always use '-' instead of '_' in build folder filenames (Frediano); Signed-off-by:
-
Victor Toso authored
Much better than playing around with shell. Logs should live for week since the build and CI will try to always upload them. This patch also adds the logs for tests from builds with autotools Signed-off-by:
-
Victor Toso authored
* On a windows job-build, we don't need to install Fedora dependencies. This change makes only one dnf install be ran per job. * On a meson build, we should build spice-protocol with meson too. Moving this before_script rule to each job makes all of this clear. So, this patch does change for fedora-meson, the build of spice-protocol with meson and we don't (explicitly) install any of $DEPS_FEDORA v1 -> v2: - Remove initial '_' from build folder filenames (Frediano); - Always use '-' instead of '_' in build folder filenames (Frediano); Signed-off-by:
-
Victor Toso authored
To keep all dependencies together. Some (small) effort was made to distinguish what is necessary for Fedora and what is necessary for Windows builds in order to install only required packages when job is executing. Note that we are adding gettext, gettext-devel and glib2-devel explicit now on DEPS_COMMON. The reason is that, both Fedora and mingw builds require some tooling but for Fedora it gets installed indirectly while for Mingw, it doesn't and configure/build would fail. Signed-off-by:
-
Victor Toso authored
Group by target build instead of command. The focus of each job is to check any regression for given platform, using 'fedora'/'windows' and 'autotools'/'meson' seems more intuitive. By doing that we are grouping similar jobs together, this is intentional as we are reducing the amount of jobs that need to be run (together with the whole bootstrapping) without losing logs or tests. Some indentation takes place too, keeping it to 2 spaces as some other places in the code v1 -> v2: - Remove initial '_' from build folder filenames (Frediano); - Always use '-' instead of '_' in build folder filenames (Frediano); Signed-off-by:
-
Victor Toso authored
The usage of testing tool as flatkpak is discouraged by upstream developers, see comments from thread: https://lists.freedesktop.org/archives/spice-devel/2019-February/047877.html One might argue that keep this might be useful for documentation. For that, please refer to updated documentation from Flatpak and applications that have adopted Flatpak integration such as GNOME Boxes. Signed-off-by:
-
- Feb 13, 2019
-
-
Daniel P. Berrange (24): Add named constants for QKeyCode values Add ability to generate enums Build tests with warnings enabled Add Sun/Sparc keyboard keycodes Add some missing mappings for USB HID Add line for QKeyCode asterisk Add line for QKeyCode print Fix AT Set2 scancode for F7 Fix AT set3 mapping for backslash Misc fixes in AT set 3 scancodes Add Apple Desktop Bus scancodes Add many missing Sun scancodes Add missing Help key entry for OS-X key codes Add support for array upper bounds with enums Handle maps where 0x0 is a valid key Fix ANSI_KeypadClear mapping for OSX Remove ??? from some keynames Fix USB menu key mapping Allow customizing the map length data type Rename 'rfb' to 'qnum' Add local argparse for compat with python 2.6 Add hack for mapping qnum 0xb7 to sysrq Fix mistake in Pause/SysRq mapping for SUN scancode Fix compat with py3 dict keys/values data types Miika S (1): Add missing QKeyCode values for JIS keyboards Olaf Hering (1): remove buildtime from generated files Paolo Bonzini (3): move CLanguageGenerator closer to CLanguageGenerator itself c++: add extern declaration to the generated file add header file generators Peter Korsgaard (1): keymap-gen: add support for generating output for C++ Pierre Ossman (16): Correct lookup of name in comment Merge XT columns Fix AT set 2 table Rename X11 keycode header to keysym Add README for data columns Add basic tests Add tests for code-table Add tests for name-map Add tests for name-table Add mapping for HTML key codes Add mapping for XKEYBOARD key names Fix some keys on macOS Handle string based codes Add support for JavaScript output Provide array size constant for C output Use STL types for C++ output Signed-off-by: -
Fix gtk-doc warnings such as: html/SpiceChannel.html:538: warning: no link for: "api-index-0.20" -> (0.20). Unfortunately, the generated file is still missing. Signed-off-by:
-
