Skip to content

[next] Fix FileTransfer ContentHash property

Submitted by Jonny Lamb @jonnylamb

Assigned to Telepathy bugs list

Link to original bug (#46783)

Description

Now that we've got a next branch, we can fix this:

FileTransfer.ContentHash is really annoying because it means the person requesting the channel must be the one who hashes the file.

We should fix this by:

  1. specifying that the file send request is sent when ProvideFile() is called, and not when the new channel is created.

  2. making ContentHash and ContentHashType mutable before ProvideFile() has been called (just like the URI property). Of course for incoming file transfers, it's always immutable.

So here is the outgoing file transfer case:

  1. request a FileTransfer channel in some dummy app with:

{ ChannelType: FileTransfer, TargetHandleType: CONTACT, TargetID: "foo@bar.com", URI="file:///home/user/party.jpg" }

  1. the appropriate channel appears and another app is activated as the handler. The handler sees the file is /home/user/party.jpg and hashes it to get the hash "abcdefghijklmnopqrstuvwxyz". So calls:

Set("FileTransfer", "ContentHashType", 1337) Set("FileTransfer", "ContentHash", "abcdefghijklmnopqrstuvwxyz")

  1. the handler then calls ProvideFile().

  2. the CM then sends the, say, SI file transfer stanza.

The incoming transfer case is pretty much the same. How does this sound then?

Version: git master

Blocking