GitLab

George Kiagiadakis authored Jul 30, 2017 and Alexandr Akulich committed Nov 16, 2019

Fixes #17

Signed-off-by: George Kiagiadakis <gkiagia@tolabaki.gr>
Signed-off-by: Alexandr Akulich <akulichalexander@gmail.com>

Gabble (correctly) doesn't implement it if you use
{ "account": "gmail.com" }, which is not enough for X-TELEPATHY-PASSWORD:
a mechanism that provides a username, such as PLAIN or Google's OAuth
dialect, must be used here.

Bug: https://bugs.freedesktop.org/show_bug.cgi?id=64354

Reviewed-by: Guillaume Desmottes <guillaume.desmottes@collabora.co.uk>

The whole point of having this interface in the spec is to not have to use an
extension in Idle. Furthemore the API is versioned so we can always change it
if we want to.

If something has been implemented without changes for 4 years, but
has not been declared core functionality in that time, then it's
clearly an optional interface.

This is a simple rename: no content changes other than the name and
the <tp:added>. Connection.FUTURE was also identical to the version
in Gabble and Salut, apart from the <tp:added>.

Bug: https://bugs.freedesktop.org/show_bug.cgi?id=70382

Reviewed-by: Guillaume Desmottes <guillaume.desmottes@collabora.co.uk>

Bug: https://bugs.freedesktop.org/show_bug.cgi?id=37380

Reviewed-by: Guillaume Desmottes <guillaume.desmottes@collabora.co.uk>

My main concern about this interface was whether implementing it
caused MC to be unmaintainable, but it isn't too bad in practice,
just unfinished.

The one edit here, relative to Mission Control, is making the
filename end with "1.xml" instead of "_DRAFT.xml", so that
subsequent diffs on the contents aren't lost in the rename noise.

Bug: https://bugs.freedesktop.org/show_bug.cgi?id=37380

Reviewed-by: Guillaume Desmottes <guillaume.desmottes@collabora.co.uk>

The implementation in Gabble hasn't changed since 2010, so it's
de facto stable. We should either spec it or delete it.

Bug: https://bugs.freedesktop.org/show_bug.cgi?id=26609

Reviewed-by: Guillaume Desmottes <guillaume.desmottes@collabora.co.uk>

The current version is identical to what's in telepathy-idle, which
has had it without implementation changes since 2007. If that's
not stable API, nothing is :-)

I deliberately haven't called it Renaming1 (although I will in the
'next' branch), so that in the unlikely event that any UI pays
attention to it, it won't need changes. Not only is Renaming older
than the Foo1 convention, it's also older than the Foo.DRAFT
convention, so it never had either.

Bug: https://bugs.freedesktop.org/show_bug.cgi?id=25147

Reviewed-by: Guillaume Desmottes <guillaume.desmottes@collabora.co.uk>

Reviewed-by: Simon McVittie <simon.mcvittie@collabora.co.uk>

Empathy has always been depending on it.

There is no change notification at the moment.

https://bugs.freedesktop.org/show_bug.cgi?id=40393

Reviewed-by: Jonny Lamb <jonny.lamb@collabora.co.uk>

Reviewed-by: Simon McVittie <simon.mcvittie@collabora.co.uk>

Signed-off-by: Jonny Lamb <jonny.lamb@collabora.co.uk>

Signed-off-by: Jonny Lamb <jonny.lamb@collabora.co.uk>

Signed-off-by: Jonny Lamb <jonny.lamb@collabora.co.uk>

"Calls Media" is not even English.
Signed-off-by: Jonny Lamb <jonny.lamb@collabora.co.uk>