Searching Pidgin log store matches search against tags
Submitted by Will Thompson @wjt
Assigned to Telepathy bugs list
Description
Created attachment 67992 demonstrates this bug in the pidgin log store
The Pidgin log store searches by just matching the query against mmaped log files using strstr(). http://cgit.freedesktop.org/telepathy/telepathy-logger/tree/telepathy-logger/log-store-pidgin.c#n901
This is great, except that it matches the names of tags as well as the contents of your messages. See the attached patch, which changes the test suite to search for "font". The only occurrence of "font" in the test suite's pidgin logs is as "<font …>" or "</font>", so it shouldn't match, but does.
The XML log store doesn't have this bug. It searches your logs with … a regex … to match XML. Which I suppose works, but… http://cgit.freedesktop.org/telepathy/telepathy-logger/tree/telepathy-logger/log-store-xml.c#n1550
Attachment 67992, "demonstrates this bug in the pidgin log store":
0001-do-not-commit-pidgin-log-store-searches-match-tags.patch
Version: git master