contact-based Group API does not process removals correctly
Submitted by Simon McVittie
Assigned to Telepathy bugs list
Description
ids = tp_asv_get_boxed (details, "contact-ids", TP_HASH_TYPE_HANDLE_IDENTIFIER_MAP); if (ids == NULL) { DEBUG ("CM did not give identifiers, can't create TpContact"); return; }
... but it's entirely normal for a group membership change that is just a removal, not an addition, to not provide any contact identifiers at all.
This results in the sets of contacts not being reliably correct, which is pretty bad if we're going to deprecate the sets of handles.
Having fixed that, I still get
ERROR:/home/smcv/src/fdo/tpglib/tests/dbus/group-mixin.c:452:in_the_desert: assertion failed (members->len == 2): (3 == 2)
when I try to use the contacts as my only group API for the tests, so I don't know quite what's going on here.
I think this indicates that we don't have enough test coverage for the contact-based group API.
Version: git master