Skip to content

Audit API in util.h and deprecate/remove what got into glib

Submitted by Xavier Claessens @xclaesse

Assigned to Telepathy bugs list

Link to original bug (#70095)

Description

  • tp_g_ptr_array_contains: Not included yet: https://bugzilla.gnome.org/show_bug.cgi?id=698064

  • tp_g_ptr_array_extend: Not included, I don't think we have a bug for it. But IIRC we use it for dbus-glib stuff so probably not needed with GVariant ?

  • tp_g_value_*: Not useful in a GVariant world, so probably not worth upstreaming.

  • tp_g_hash_table_update: not sure how useful it is when using GVariant...

  • tp_str_empty: I can't believe they are seriously rejecting that... https://bugzilla.gnome.org/show_bug.cgi?id=399880

  • tp_strdiff: same: https://bugzilla.gnome.org/show_bug.cgi?id=685878

  • tp_escape_as_identifier: do we want to upstream?

  • tp_strv_contains: not there yet: https://bugzilla.gnome.org/show_bug.cgi?id=685880

  • tp_g_signal_connect_object: I think we should deprecate it and remove from next.

  • tp_value_array_build, tp_value_array_unpack, tp_value_array_free: Not useful with GVariant.

  • TpWeakRef: GLib has GWeakRef now. It's not exactly the same since it does not have extra gpointer user_data and it's missing g_weak_ref_new(). It should be easy to get g_weak_ref_new() upstream and maybe add tp_g_weak_ref_new() in the meantime. Should we deprecate TpWeakRef and remove from next?

  • tp_clear_pointer: Can be deprecated/removed if we don't mind the extra threadsafeness of g_clear_pointer.

  • tp_clear_object: Can be deprecated/removed.

  • tp_simple_async_report_success_in_idle: We should deprecate/remove in favor of GTask API.

  • tp_user_action_time_from_x11, tp_user_action_time_should_present: Makes no sense to upstream, right?

  • tp_utf8_make_valid: Still not in glib: https://bugzilla.gnome.org/show_bug.cgi?id=610969

We also have util-internal that can be cleaned:

  • tp_implement_finish*: We should use GTask instead which is easier to implement _finish() functions.

  • _tp_object_list_copy: I think g_list_copy_deep(list, g_object_ref) should be good enough now.

  • _tp_object_list_free: g_list_free_full(list, g_object_unref) should be enough.

  • _tp_g_list_copy_deep: we have g_list_copy_deep since 2.34

Version: git master

Blocking