Skip to content

TpBasePasswordChannel does not wait to see if server accepts the password before claiming success

Submitted by Xavier Claessens @xclaesse

Assigned to Telepathy bugs list

Link to original bug (#64869)

Description

Steps:

  1. create a yahoo account with wrong password into UOA
  2. put that account online
  3. see that account fails to connect but UOA is not asking user to re-type the password

What happens: When tp-haze wants to connect, it uses TpBasePasswordChannel to get a password via the SASL system. empathy-auth-client then catch the channel and call StartWithData with the password stored in UOA. The tp_base_password_channel_start_mechanism_with_data() unconditionally moves status to TP_SASL_STATUS_SERVER_SUCCEEDED instead of actually giving the password to the server and move status to TP_SASL_STATUS_SERVER_SUCCEEDED/FAILED depending on the result.