Skip to content

Review Conn.I.Resources

Submitted by Jonny Lamb @jonnylamb

Assigned to Jonny Lamb @jonnylamb

Link to original bug (#30461)

Description

Simon already made a few comments:

Regarding Gabble:

Regression tests are good, and should have caught this:

  • if (name == g_quark_from_static_string ("MailNotificationFlags"))
  • g_value_set_uint (value, GABBLE_RESOURCES_HUMAN_READABILITY_MAYBE); ^^^^^^^^^^^^^^^^^^^^^

+static const gchar * +presence_id_to_status (GabblePresenceId id,

  • TpConnectionPresenceType *type)

Surely this must be duplicating something in conn-presence.c? (It's entirely possible that the information exists in conn-presence.c but needs some refactoring, though.)

(Be particularly careful about Senko's new plugin-defined presences, which can be visible on the self-handle (if the self-resource is exposed) and didn't exist when you wrote this branch...)

  •  val = tp_g_value_slice_new_boxed (
  •      GABBLE_HASH_TYPE_RESOURCE_INFORMATION_MAP, resources);

[...]

  •  g_hash_table_unref (resources);

Just take_boxed to avoid a copy?

Version: git master