• Alyssa Rosenzweig's avatar
    panfrost: Don't flip scanout · 2adf35e4
    Alyssa Rosenzweig authored
    The mesa/st flips the viewport, so we respect that rather than
    trying to flip the framebuffer itself and ignoring the viewport and
    using a messy heuristic.
    However, this brings an underlying disagreement about the interpretation
    of winding order to light. The blob uses a different strategy than Mesa
    for handling viewport Y flipping, so the meanings of the winding order
    bit are flipped for it. To keep things clean on our end, we rename to
    explicitly use Gallium (rather than flipped OpenGL) conventions.
    Fixes upside-down Xwayland/egl windows.
    v2: Adjust lowering configuration to correctly flip gl_PointCoord.y and
    gl_FragCoord.y. v1 was R-b'd by Tomeu, but then retracted due to these
    regressions which are not fixed.
    Suggested-by: Rob Clark's avatarRob Clark <robdclark@chromium.org>
    Signed-off-by: Alyssa Rosenzweig's avatarAlyssa Rosenzweig <alyssa.rosenzweig@collabora.com>
    Sort-of-reviewed-by: default avatarTomeu Vizoso <tomeu.vizoso@collabora.com>
decode.c 79.5 KB