Skip to content
GitLab
Switch branch/tag
  1. 29 Sep, 2021 1 commit
  3. 30 Nov, 2020 1 commit
  5. 30 Oct, 2020 1 commit
  7. 28 Oct, 2020 1 commit
  9. 22 Oct, 2020 1 commit
  11. 02 Oct, 2020 1 commit
  13. 29 Sep, 2020 2 commits
  15. 10 Sep, 2020 1 commit
  17. 08 Sep, 2020 3 commits
  19. 03 Sep, 2020 1 commit
    • Sebastian Wick's avatar
      color management: protocol fixes and color_space_creator object · 9466f79b
      Sebastian Wick authored 
      

* creating a color space now leads through the color_space_creator
  object which allows us to fail at ceating the color space
* there are now three ways to create a color space. From an ICC profile,
  from well-known names and parametrically.
* multiple color_management_outputs can now be created for a single
  wl_output
* color_space_changed is not send when the object is created anymore
* clearify that destroying a color space has no effect on the color
  space state associated with surfaces and outputs
* preferred color space is send only after it is determined or changed
* preferred color space is send to all matching wl_outputs
Signed-off-by: Sebastian Wick's avatarSebastian Wick <sebastian@sebastianwick.net>
      9466f79b
  21. 20 Aug, 2020 1 commit
  23. 11 Aug, 2020 1 commit
  25. 29 Feb, 2020 6 commits
    • Jonas Ådahl's avatar
      configure.ac: Bump version to 1.20 · b0a25f26
      Jonas Ådahl authored 
      
Signed-off-by: Jonas Ådahl's avatarJonas Ådahl <jadahl@gmail.com>
      b0a25f26
    • Jonas Ådahl's avatar
      Makefile.am: Also distribute README.md, GOVERNANCE.md and MEMBERS.md · 035ffedd
      Jonas Ådahl authored 
      

README was distributed by default due to implicit autotools rules, so
when we renamed to README.md, it stopped being included. While at it,
also add the two other new files.
Signed-off-by: Jonas Ådahl's avatarJonas Ådahl <jadahl@gmail.com>
      035ffedd
    • Jonas Ådahl's avatar
      configure.ac: Bump version to 1.19 · 8f6095f2
      Jonas Ådahl authored 
      
Signed-off-by: Jonas Ådahl's avatarJonas Ådahl <jadahl@gmail.com>
      8f6095f2
    • Jonas Ådahl's avatar
      xdg-shell: Add support for explicit popup repositioning · 26f494ed
      Jonas Ådahl authored 
      

This commit adds protocol additions making it possible to request that a
popup should be repositioned according to a new xdg_positioner object.

Explicit popup moving is done using a new request on xdg_popup:
xdg_popup.reposition. What it does is change the parameters used for
positioning a popup by providing a new xdg_positioner object. This
request is coupled with a new event; xdg_popup.repositioned, sent
together with the configure events (xdg_popup.configure and
xdg_surface.configure) to notify about the completion of the reposition
request. The reposition request also takes a token that is later passed
via the repositioned event; this is done so that a client may determine
for which reposition request the compositor has sent configure events.

Synchronization between surfaces to avoid state application race
condition are deliberately left out, and should be handled by an
external protocol.

To brief the compositor of the future dimension of the parent that the
compositor should position the popup against, a
xdg_positioner.set_parent_size request is added.

Lastly, a request to couple a xdg_positioner object with a parent
configure event is added (xdg_positioner.set_parent_configure) in
order for a compositor to pair a popup reposition request with a pending
configure event, and it's resulting window geometry. This is necessary
to, for example, properly constrain a popup given a future parent state.
An example of when this may be necessary is an interactive resize where
both the toplevel position and the relative popup position changes.
Signed-off-by: Jonas Ådahl's avatarJonas Ådahl <jadahl@gmail.com>
Reviewed-by: Mike Blumenkrantz's avatarMike Blumenkrantz <michael.blumenkrantz@gmail.com>
Reviewed-by: Simon Ser's avatarSimon Ser <contact@emersion.fr>
      26f494ed
    • Jonas Ådahl's avatar
      xdg-shell: Add support for implicit popup repositioning · ebbad29e
      Jonas Ådahl authored 
      

This commit adds protocol additions making it possible to implicitly
reposition an already mapped popup if the conditions for the constraint
changed (e.g. toplevel moved).

Implicit popup moving is done by setting a adjustment flag on the
positioner used to create it that will cause the compositor to adjust
the position as the conditions used to constrain it change.

These changes may include, for example, changes in the position of the
parent window or the geometry of the work area. To allow the client to
update its content in response to the updated position, the client must
ack the configure event, optionally with new content. Until the client
acks this configure event, the existing positioner will continue to be
used.

Implicit repositioning by itself is racy regarding inter-surface
synchronization of applied state. Inter-surface synchronization is
deliberately left out of xdg-shell, and left to be handled externally.
Signed-off-by: Jonas Ådahl's avatarJonas Ådahl <jadahl@gmail.com>
Reviewed-by: Mike Blumenkrantz's avatarMike Blumenkrantz <michael.blumenkrantz@gmail.com>
Reviewed-by: Simon Ser's avatarSimon Ser <contact@emersion.fr>
      ebbad29e
    • Jonas Ådahl's avatar
      xdg-shell: Remove left-over paragraph from pre positioner versions · 2b0c87ea
      Jonas Ådahl authored 
      

It mentioned the now removed x, y parameters of xdg_surface.get_popup.
The xdg_positioner now has the relevant documentation that was
previously documented by the now removed paragraph.
Signed-off-by: Jonas Ådahl's avatarJonas Ådahl <jadahl@gmail.com>
Reviewed-by: Simon Ser's avatarSimon Ser <contact@emersion.fr>
      2b0c87ea
  27. 25 Feb, 2020 1 commit
  29. 22 Jan, 2020 1 commit
  31. 18 Dec, 2019 1 commit
    • Simon Ser's avatar
      Convert plaintext documents to Markdown · 733de762
      Simon Ser authored 
      

This converts GOVERNANCE, MEMBERS and README to Markdown documents.
These are only cosmetic changes, the actual contents and wording have
been retained.

GitLab pretty-prints Markdown and adds anchors. We can now add links
from one document to another.

Unfortunately GOVERNANCE lettered lists have been converted to numbered
lists, because Markdown doesn't support the former.
Signed-off-by: Simon Ser's avatarSimon Ser <contact@emersion.fr>
Closes: #3
      733de762
  33. 21 Nov, 2019 2 commits
  35. 20 Nov, 2019 2 commits
  37. 06 Sep, 2019 1 commit
  39. 25 Jul, 2019 2 commits
  41. 17 Jul, 2019 3 commits
    • Jan-Marek Glogowski's avatar
      xdg-shell: use case to change the app ID at runtime · e0d6ad1d
      Jan-Marek Glogowski authored and Jonas Ådahl's avatar Jonas Ådahl committed 
      

LibreOffice is one big binary with explicit brandings for different
application modules. This is represented in X11 by a different
WM_CLASS setting for a window. The WM_CLASS is changed based on the
loaded document at runtime. As a result LibreOffice already offers
multiple desktop files with different icons, StartupWMClass
entries and application names.

This amendment of the set_app_id request just explicitly specifies
the use case to change a surfaces' app ID at runtime, so a compositor
implementor is made aware of it. Just as the WM_CLASS, a change of
the app ID should result in an update of the propertes of a surface
depending on the app ID, like the window icon specified in the
desktop file or a re-grouping of the surfaces in a task manager.
Signed-off-by: Jan-Marek Glogowski's avatarJan-Marek Glogowski <glogow@fbihome.de>
Reviewed-by: Jonas Ådahl's avatarJonas Ådahl <jadahl@gmail.com>
Reviewed-by: Simon Ser's avatarSimon Ser <contact@emersion.fr>
      e0d6ad1d
    • Simon Ser's avatar
      pointer-gestures: add a release request · b9d427db
      Simon Ser authored and Jonas Ådahl's avatar Jonas Ådahl committed 
      

This allows clients to destroy a gesture object before they disconnect.

The request isn't named "destroy", as this would conflict with
wayland-scanner's auto-generated destructor (which just destroys the
client-side object without sending any request).
Signed-off-by: Simon Ser's avatarSimon Ser <contact@emersion.fr>
Reviewed-by: Jonas Ådahl's avatarJonas Ådahl <jadahl@gmail.com>
      b9d427db
    • Simon Ser's avatar
      xdg-output: deprecate the xdg_output.done event · 962dd535
      Simon Ser authored and Jonas Ådahl's avatar Jonas Ådahl committed 
      This commit makes it so a wl_output.done event is guaranteed to be sent with a
xdg_output.done event.

This protocol change has been discussed in a recent xorg-devel discussions [1].

First let's recap why a change is needed: Xwayland listens to both wl_output and
xdg_output changes. When an output's properties change, Xwayland expects to
receive both a wl_output.done event and an xdg_output.done event. If that's not
the case, Xwayland doesn't update its state (so old state is still exposed to
X11 clients).

Most of the time, both objects will be updated at the same time (e.g. the
current mode is changed, so both wl_output.mode and xdg_output.logical_size are
sent) so this won't be an issue. However in some situations only one of
wl_output or xdg_output changes. For instance:

- The mode is changed at the same time as the scale, resulting in the same
  logical_size.
- The compositor doesn't expose the outputs' position via wl_output, so whenever
  the position changes only xdg_output is updated.

Both KDE [2] and wlroots [3] have experienced this issue.

For this reason, I'd like to update the xdg-output protocol to make it mandatory
to always send a wl_output.done event after xdg_output changes. This effectively
makes wl_output.done atomically apply all output state (including the state of
add-on objects like xdg_output). This approach is pretty similar to
wl_surface.commit: this request will atomically apply surface state including
the state of e.g. the xdg_surface object tied to the wl_surface.

To update the protocol to reflect this new requirement we can either:

- **Bump xdg_output version**. The current protocol doesn't specify that
  wl_output.done must be sent, adding this new requirement would be a breaking
  change. We need to fix Xwayland for the current xdg_output version (maybe make
  it non-atomic for the current version, atomic for the new one?). Should we
  deprecate xdg_output.done in the new version?
- **Don't bump xdg_output version**. This clarifies what is expected in practice
  by Xwayland, a major xdg_output consumer, and what is currently implemented by
  all compositors.

There's one issue with the "don't bump" approach: indeed in practice compositors
always send wl_output.done and xdg_output.done in pairs, however the ordering
between those two events is not guaranteed. This means some compositors might
send this sequence:

    wl_output.geometry(…)
    wl_output.done()
    xdg_output.logical_position(…)
    xdg_output.done()

In this case the wl_output.done event fails to atomically apply the xdg_output
state.

For this reason, I think bumping the version is a better approach.

This commit also deprecates xdg_output.done, which doesn't have any purpose
anymore.

[1]: https://lists.x.org/archives/xorg-devel/2019-April/058148.html
[2]: https://phabricator.kde.org/D19253
[3]: https://github.com/swaywm/sway/issues/4064

Signed-off-by: Simon Ser's avatarSimon Ser <contact@emersion.fr>
Reviewed-by: Olivier Fourdan's avatarOlivier Fourdan <ofourdan@redhat.com>
Reviewed-by: Jonas Ådahl's avatarJonas Ådahl <jadahl@gmail.com>
      962dd535
  43. 22 May, 2019 1 commit
  45. 02 May, 2019 1 commit
  47. 17 Jan, 2019 1 commit
  49. 14 Dec, 2018 3 commits