GitLab

The gettext in fprintd would be getting confused by a new file in
libfprint that looks like it should have been translated. Ignore this
file in our build.

and simplify the flow of that function.

From https://bugs.launchpad.net/ubuntu/+source/fprintd/+bug/1745455/comments/7

No need to duplicate that string until we pass it out.

From https://bugs.launchpad.net/ubuntu/+source/fprintd/+bug/1745455/comments/7

This will be a warning with slightly older versions of libfprint, but at
least it would catch errors.

I doubt we want to do this, and nothing has needed it so far.

See #10

See #9

Already registered in Transifex:
https://www.transifex.com/freedesktop/fprintd/

See #8

Fix a possible crash when an fprintd client disappears. If the client
requested for the device to be released, then, without waiting for the
reply of that release, disappeared from the bus, we would try to close
it a second time, accessing a function pointer that didn't exist
anymore.

See https://bugzilla.redhat.com/show_bug.cgi?id=1515720

Rather than filling the logs with mostly useless messages, print those
as debug.

To make it easier to use as an example.

Remove do/while loops in favour of for loops, and downgrade some
warnings and messages statements to debug.

And add Belarusian

When starting the daemon

If not all the functions in the header are used, we'd get warnings about
them being unused. Mark all the functions as unused, so we can avoid
warnings.

Don't try to copy a file over itself if srcdir == builddir

Using the NoNewPrivileges stanza from systemd.

Christian Kellner authored Feb 16, 2017 and Bastien Nocera committed Feb 16, 2017

The error should be initialised to NULL before being set.

Christian Kellner authored Feb 16, 2017 and Bastien Nocera committed Feb 16, 2017

So free the errors after sending them on the bus.

https://bugs.freedesktop.org/show_bug.cgi?id=99838

Christian Kellner authored Feb 16, 2017 and Bastien Nocera committed Feb 16, 2017

Before claiming the device and therefore potentially activating
the actual hardware, make a call to see if the user has any
prints registered at all.

https://bugs.freedesktop.org/show_bug.cgi?id=99811

Christian Kellner authored Feb 16, 2017 and Bastien Nocera committed Feb 16, 2017

For some operations, i.e. listing the enrolled prints, the device
does not need to be claimed. Therefore the claiming can be delayed
until we actually start the verification process, allowing us to
query the fingerprint system if the user has any prints enrolled.

https://bugs.freedesktop.org/show_bug.cgi?id=99811

Christian Kellner authored Feb 14, 2017 and Bastien Nocera committed Feb 14, 2017

Calling g_type_init() is not needed anymore and deprecated since
glib version 2.36.

https://bugs.freedesktop.org/show_bug.cgi?id=99812

Christian Kellner authored Feb 14, 2017 and Bastien Nocera committed Feb 14, 2017

Calling g_type_init() is not needed anymore and deprecated since
glib version 2.36.

https://bugs.freedesktop.org/show_bug.cgi?id=99812

Christian Kellner authored Feb 14, 2017 and Bastien Nocera committed Feb 14, 2017

Calling g_type_init() is not needed anymore and deprecated since
glib version 2.36.

https://bugs.freedesktop.org/show_bug.cgi?id=99812

Christian Kellner authored Feb 14, 2017 and Bastien Nocera committed Feb 14, 2017

dbus_g_method_get_sender() returns an allocated-string which we need to
free. This is handled properly in the rest of the codebase.

https://bugs.freedesktop.org/show_bug.cgi?id=99811

Piotr Drąg authored Feb 11, 2017 and Bastien Nocera committed Feb 11, 2017

https://bugs.freedesktop.org/show_bug.cgi?id=99773

Give read-write access to USB devices in /dev, and the location of the
fingerprints, access to Unix sockets for D-Bus and
close everything else down.

See systemd.exec(5) for details about the options.