Skip to content
  1. Jan 17, 2019
  2. Jan 03, 2019
  3. Dec 18, 2018
    • maurossi's avatar
      android: Fix 32-bit app crashing in 64-bit Android · 597725e9
      maurossi authored
      
      
      Seemingly the 64-bit int is always aligned to 8 in LP64.
      But this is not hold in LP32.
      
      Consequently sizeof(gralloc_drm_handle_t) are different
      between LP64 (which is 18 ints) and LP32 (which is 16 ints).
      As a result, 32-bit apps will crash in 64-bit OS since the
      checking handle->base.numInts != GRALLOC_GBM_HANDLE_NUM_INTS
      is true.
      
      Fix it by always aligning 64-bit int to 8. Besides, to avoid
      additional padding, just exchange the order of data_owner
      and modifier. It aligns modifier to 8 natually.
      This makes gralloc_drm_handle_t fit in 16 ints perfectly.
      
      (v2) gralloc_drm_handle.h patch now applied in gralloc_handle.h
           and GRALLOC_HANDLE_VERSION updated to 4
      
      Reported-by: default avatarMauro Rossi <issor.oruam@gmail.com>
      Signed-off-by: default avatarChih-Wei Huang <cwhuang@linux.org.tw>
      Reviewed-by: default avatarRobert Foss <robert.foss@collabora.com>
      597725e9
  4. Dec 17, 2018
  5. Dec 14, 2018
  6. Dec 11, 2018
  7. Dec 05, 2018
  8. Nov 20, 2018
  9. Nov 11, 2018
  10. Nov 09, 2018
  11. Nov 02, 2018
  12. Nov 01, 2018
  13. Oct 17, 2018
  14. Oct 16, 2018
  15. Oct 14, 2018
  16. Oct 13, 2018
  17. Oct 10, 2018
  18. Oct 09, 2018
  19. Oct 04, 2018
Loading