1. 20 Aug, 2019 3 commits
  2. 07 Aug, 2019 1 commit
  3. 05 Aug, 2019 1 commit
  4. 01 Aug, 2019 2 commits
  5. 26 Jul, 2019 5 commits
  6. 24 Jul, 2019 2 commits
  7. 23 Jul, 2019 2 commits
  8. 15 Jul, 2019 1 commit
  9. 12 Jul, 2019 1 commit
    • Brendan Shanks's avatar
      Fix segfault when quitting with Quit button · c0f36257
      Brendan Shanks authored
      Quitting with the Quit button or closing the window always causes a
      segfault for me. Destroying the surface before removing the interface
      seems to resolve the problem.
      
      log from valgrind:
      ==7741== Invalid read of size 8
      ==7741==    at 0x6943517: red_qxl_destroy_primary_surface_sync (red-qxl.c:313)
      ==7741==    by 0x6943517: red_qxl_destroy_primary_surface (red-qxl.c:338)
      ==7741==    by 0x6943517: spice_qxl_destroy_primary_surface (red-qxl.c:696)
      ==7741==    by 0x111F60: spice_destroy_primary (spice.c:506)
      ==7741==    by 0x111F60: spice_end (spice.c:694)
      ==7741==    by 0x10CBDA: main (main.c:154)
      ==7741==  Address 0x88 is not stack'd, malloc'd or (recently) free'd
      ==7741==
      ==7741==
      ==7741== Process terminating with default action of signal 11 (SIGSEGV)
      ==7741==  Access not within mapped region at address 0x88
      ==7741==    at 0x6943517: red_qxl_destroy_primary_surface_sync (red-qxl.c:313)
      ==7741==    by 0x6943517: red_qxl_destroy_primary_surface (red-qxl.c:338)
      ==7741==    by 0x6943517: spice_qxl_destroy_primary_surface (red-qxl.c:696)
      ==7741==    by 0x111F60: spice_destroy_primary (spice.c:506)
      ==7741==    by 0x111F60: spice_end (spice.c:694)
      ==7741==    by 0x10CBDA: main (main.c:154)
      Signed-off-by: Brendan Shanks's avatarBrendan Shanks <bshanks@codeweavers.com>
      Acked-by: Frediano Ziglio's avatarFrediano Ziglio <fziglio@redhat.com>
      c0f36257
  10. 19 Jun, 2019 1 commit
  11. 03 May, 2019 5 commits
  12. 05 Feb, 2018 1 commit
  13. 03 Feb, 2018 2 commits
    • Sam Protsenko's avatar
      Fix -Wformat-security error · c8879bfa
      Sam Protsenko authored
      As -Werror flag is used in src/Makefile.am, next error occurs:
      
          gui.c: In function ‘gui_report_error’:
          gui.c:134:17: error: format not a string literal and no
                        format arguments [-Werror=format-security]
                        message);
      
      Disable -Wformat-security in order to fix the build, before the code is
      actually fixed.
      Signed-off-by: default avatarSam Protsenko <joe.skb7@gmail.com>
      c8879bfa
    • Sam Protsenko's avatar
      tests: Fix incorrect order of linker flags · b4c0354a
      Sam Protsenko authored
      Libraries flags (like -lglib-2.0) should be provided in the end of
      compile command. It's not how it's done right now in tests/Makefile.am,
      because _LDFLAGS is used where we should actually use _LDADD. Due to
      this, on Ubuntu 16.04 with GCC 5 we have next linking errors:
      
          gcc -lxcb-damage -lxcb-xfixes -lxcb-render -lxcb-shape -lxcb
              -lxcb-xtest -lxcb -lxcb-shm -lxcb -lxcb-util -lxcb -lgtk-x11-2.0
              -lgdk-x11-2.0 -lpangocairo-1.0 -latk-1.0 -lcairo -lgdk_pixbuf-2.0
              -lgio-2.0 -lpangoft2-1.0 -lpango-1.0 -lgobject-2.0 -lglib-2.0
              -lfontconfig -lfreetype -lspice-server -lglib-2.0 -lpixman-1
              -o x11spice_test tests.o x11spice_test.o xcb.o xdummy.o util.o
              main.o  -laudit
      
          tests.o: In function `check_binary':
          src/tests/tests.c:83: undefined reference to `g_log'
          src/tests/tests.c:84: undefined reference to `g_test_skip'
          tests.o: In function `test_common_start':
          src/tests/tests.c:46: undefined reference to `g_test_build_filename'
          src/tests/tests.c:56: undefined reference to `g_log'
          src/tests/tests.c:57: undefined reference to `g_test_fail'
          src/tests/tests.c:39: undefined reference to `g_test_skip'
          src/tests/tests.c:48: undefined reference to `g_log'
          src/tests/tests.c:49: undefined reference to `g_test_fail'
      
      Use _LDADD instead of _LDFLAGS for libs, so that libraries are
      specified in the end of compile line.
      Signed-off-by: default avatarSam Protsenko <joe.skb7@gmail.com>
      b4c0354a
  14. 16 Jan, 2017 1 commit
  15. 13 Jan, 2017 3 commits
  16. 08 Dec, 2016 1 commit
  17. 03 Nov, 2016 1 commit
  18. 02 Nov, 2016 2 commits
  19. 01 Nov, 2016 1 commit
  20. 31 Oct, 2016 2 commits
  21. 27 Oct, 2016 1 commit
  22. 10 Oct, 2016 1 commit