GitLab

This is nice for helping users with a fixed binary,
so they do not have to recompile to generate forensics.
Acked-by: Frediano Ziglio <fziglio@redhat.com>

Fixes a bug introduced by the 1.2 script change.
Acked-by: Frediano Ziglio <fziglio@redhat.com>

Maintain the executable security but allows to have a working
X11 module. X11 modules cannot be compiled with "-z now" due to
the way X11 modules work.
Signed-off-by: Frediano Ziglio <freddy77@gmail.com>

This allows rpm to be build with a simpler

rpmbuild -ta x11spice-1.2.tar.gz
Signed-off-by: Frediano Ziglio <freddy77@gmail.com>

Acked-by: Frediano Ziglio <fziglio@redhat.com>

Acked-by: Frediano Ziglio <fziglio@redhat.com>

Let's not have a separate changelog for that driver.
Acked-by: Frediano Ziglio <fziglio@redhat.com>

This makes it more user friendly and enables it to run from
an installed location, rather than just the source tree.

This also adds the ability to add '--query hostname' which
will query an XDMCP server for a session, rather than relying
on xinit.
Acked-by: Frediano Ziglio <fziglio@redhat.com>

Prevents rpm build failures when -Werror=format-security is used.

You will get occasional screen glitches; you could observe
this doing an 'ls; clear' pattern again and again.

This was caused by the full screen optimization made in 97517317
which can cause some scan reports to be incorrectly discarded.

Full disclosure:  I modified Brendan's original patch to introduce
this bug, so the blame is mine alone.
Acked-by: Frediano Ziglio <fziglio@redhat.com>

It was not clear that a lot of tests were here just to handle
borders.
Signed-off-by: Frediano Ziglio <freddy77@gmail.com>

Signed-off-by: Frediano Ziglio <freddy77@gmail.com>

Signed-off-by: Frediano Ziglio <freddy77@gmail.com>

These arrays are just used to store if the tile is changed.
This produces a bit more optimised code, is more readable
and it's clear it's a boolean value.
Signed-off-by: Frediano Ziglio <freddy77@gmail.com>

Signed-off-by: Frediano Ziglio <freddy77@gmail.com>

This saves time waiting for spin up.
Acked-by: Frediano Ziglio <fziglio@redhat.com>

Acked-by: Frediano Ziglio <fziglio@redhat.com>

This makes the treatment of the logic condition in display.c
match that of scan.c.
Acked-by: Frediano Ziglio <fziglio@redhat.com>

This option will bypass XDamage and periodic scanning and simply
transmit the whole screen to the spice server at the specified rate.

This will allow the streaming logic to kick in and hopefully for
video codecs to optimize the transmission.  This is particularly
useful for applications that often change the whole screen.
Acked-by: Frediano Ziglio <fziglio@redhat.com>

It was previously inconsistent, with partial initialization
outside and partial initialization inside.

Noted by Frediano Ziglio.
Acked-by: Frediano Ziglio <fziglio@redhat.com>

Acked-by: Frediano Ziglio <fziglio@redhat.com>

Credit to Frediano Ziglio.
Acked-by: Frediano Ziglio <fziglio@redhat.com>

This goes further than commit cb122392 by forcing a whole screen
scan, looking for changes.

This improves the feel of using a session with mutter, which is
quite noticeable in a terminal window.
Acked-by: Frediano Ziglio <fziglio@redhat.com>

There is no need to increase our CPU usage if we're going
to be largely responding to full screen painting requests
from a window manager such as mutter.
Acked-by: Frediano Ziglio <fziglio@redhat.com>

This bug became noticable after cb122392, in that we routinely
send a new scan report type, which should not affect region
tracking.

Investigating this revealed that this code was also buggy
in that the region code could cause non region related
scan reports to be discarded.  The code was refactored
to avoid that case.
Acked-by: Frediano Ziglio <fziglio@redhat.com>

Acked-by: Frediano Ziglio <fziglio@redhat.com>

Acked-by: Frediano Ziglio <fziglio@redhat.com>

Acked-by: Frediano Ziglio <fziglio@redhat.com>

Acked-by: Frediano Ziglio <fziglio@redhat.com>

These use a refined version of the doc/spice_indent tool to make sure
that all controlled sources follow the spice style guide.
Acked-by: Frediano Ziglio <fziglio@redhat.com>

There are times when the spice screen is not updated
insantaneously; this is particularly true when we are
not using damage.

Let's add a little delay to allow images to settle.

This makes testing more consistent and robust.

The previous logic assumes that the vertical height divided
by NUM_SCANLINES is less or equal to NUM_SCANLINES.

For large displays, this is clearly wrong.  The new logic
scales with vertical height.
Signed-off-by: Jeremy White <jwhite@codeweavers.com>

This exposes a bug in the current code base.  That is, we
do not scan beyond the 32 scan lines currently given.

That means if we have a screen taller than 1024 pixels, we will
not scan every block fully, and so we can miss changes.

This test exposes that issue, and currently fails.

Our functions should really not be named xcb_xxx.

If the number of vertical lines results in an odd dividend, we were
truncating the computation and not sending the last few lines.

This fixes that by first avoiding early division which would truncate
values, and by then rounding up our width and height calculations.

This fixes the bug in the tests introduced in the previous patch.

This is not expected to be useful in production, but it will
be useful in developing tests.

With compositing window managers like mutter, when used with the
spice-video-dummy, you can get damage reports that are the whole screen.

Essentially, you just get an indication that the screen has changed,
but no sense of what has changed.

This change detects that behavior and stops trusting those damage
reports, and instead increases the scan frequency to compensate.
Acked-by: Frediano Ziglio <fziglio@redhat.com>

Acked-by: Frediano Ziglio <fziglio@redhat.com>

Acked-by: Frediano Ziglio <fziglio@redhat.com>