Signed-off-by: Frediano Ziglio <freddy77@gmail.com>

This fixes the issue during CI build:

  ./configure: line 5219: AX_CXX_COMPILE_STDCXX_11: command not found

Signed-off-by: Frediano Ziglio <freddy77@gmail.com>

Remove an alignment warning

vdagent/vdagent.cpp: In member function 'bool VDAgent::handle_announce_capabilities(const VDAgentAnnounceCapabilities*, uint32_t)':
vdagent/vdagent.cpp:1048:48: warning: taking address of packed member of 'VDAgentAnnounceCapabilities' may result in an unaligned pointer value [-Waddress-of-packed-member]
 1048 |     _client_caps.assign(announce_capabilities->caps, announce_capabilities->caps + caps_size);
      |                         ~~~~~~~~~~~~~~~~~~~~~~~^~~~

Not a real issue, just annoying.

Signed-off-by: Frediano Ziglio <freddy77@gmail.com>

vcpkg update is time consuming, just use a more recent version.

Signed-off-by: Frediano Ziglio <freddy77@gmail.com>

Do not use Unix suffix under MSVC (for MingW is fine, not for
Microsoft standards where .lib is used).

Signed-off-by: Frediano Ziglio <freddy77@gmail.com>

Tell the specific library which is not static.
Previously any would be reported as libpng.

This fixes #17



Signed-off-by: Frediano Ziglio <freddy77@gmail.com>
Acked-by: Jakub Janků <jjanku@redhat.com>

imagemagick.tool is currently broken, use imagemagick.

Signed-off-by: Frediano Ziglio <freddy77@gmail.com>

This brings in the following changes:

Frediano Ziglio (4):
      build: Do not use mingw_ninja_install macro in spec file
      Release 0.14.3
      build-sys: post-release version bump to 0.14.4
      protocol: Fix enumeration deprecation for Visual Studio

Marc-André Lureau (1):
      vdagent: add a MonitorsMM field to VDAgentMonitorsConfig

SimonP (1):
      protocol: Add support for side mouse buttons

This update allow to fix an issue with Microsoft compiler.

Signed-off-by: Frediano Ziglio <freddy77@gmail.com>

Frediano Ziglio authored Aug 17, 2017 and Frediano Ziglio committed Oct 25, 2020

Enable NX (prevent data to be executable) and ASLR (address
randomisation).

Signed-off-by: Frediano Ziglio <fziglio@redhat.com>
Acked-by: Uri Lublin <uril@redhat.com>

Jakub Janků authored Jul 03, 2020 and Frediano Ziglio committed Jul 31, 2020

When the user wants to copy files, new spice-gtk can share those
files using the existing phodav server. In that case, it advertises
the VD_AGENT_CLIPBOARD_FILE_LIST type in the clipboard grab message.

Upon request of the clipboard data in the mentioned type, spice-gtk
provides a list of absolute paths in the phodav server - these are
the files that are supposed to be copied/moved.

The role of the vdagent is to adjust this data given the drive
letter of the mapped webdav share.

Files can be both copied and moved, although move was tested
only with Windows' File Explorer.

Copying files from the vdagnet side to the client is not
supported yet.

Signed-off-by: Jakub Janků <jjanku@redhat.com>
Acked-by: Frediano Ziglio <fziglio@redhat.com>

Signed-off-by: Frediano Ziglio <freddy77@gmail.com>
Acked-by: Julien Ropé <jrope@redhat.com>

The function only change DesktopLayout.

Signed-off-by: Frediano Ziglio <freddy77@gmail.com>
Acked-by: Julien Ropé <jrope@redhat.com>

Signed-off-by: Frediano Ziglio <freddy77@gmail.com>
Acked-by: Julien Ropé <jrope@redhat.com>

Citrix Workspace add 8 additional displays for off-line usage.
Ignore them like for mirrored displays.

This fixes #8

.

Signed-off-by: Frediano Ziglio <freddy77@gmail.com>
Acked-by: Julien Ropé <jrope@redhat.com>

Reduce code duplication, the enumeration happens 3 times.

Signed-off-by: Frediano Ziglio <freddy77@gmail.com>
Acked-by: Julien Ropé <jrope@redhat.com>

For other strings resolution is reported as "WxH", no spaces
around "x".

Signed-off-by: Frediano Ziglio <freddy77@gmail.com>
Acked-by: Francesco Giudici <fgiudici@redhat.com>

Frediano Ziglio authored Mar 18, 2020 and Frediano Ziglio committed May 25, 2020

A literal constant is used for error type as the project is not
dependent on glib2 and that Visual Studio and CMake are supported
so it would make the compilation on some environment more complicated
than actually is just for a constant.

Signed-off-by: Frediano Ziglio <fziglio@redhat.com>
Acked-by: Kevin Pouget <kpouget@redhat.com>
Acked-by: Victor Toso <victortoso@redhat.com>

Reduce code and avoids to forget to unlock() in the future.

Signed-off-by: Frediano Ziglio <freddy77@gmail.com>
Acked-by: Kevin Pouget <kpouget@redhat.com>

If the client closes the connection while having pending large messages
(split into multiple chunks) the state is not correctly reset causing
next client messages to be not correctly handled.

This can occur for instance if the client is closed (or killed) while
transferring a large file.

This fixes https://bugzilla.redhat.com/show_bug.cgi?id=1548419

.

Signed-off-by: Frediano Ziglio <freddy77@gmail.com>
Acked-by: Victor Toso <victortoso@redhat.com>

The client is sending messages that are compatible with agent
capabilities but also encoded with capabilities it knows of so to
check them we need to consider final capabilities, not client ones.

This fixes a regression introduced with
"vdagent: Reuse agent_check_message" where some messages were wrongly
interpreted as wrong (particularly some clipboard messages).

Signed-off-by: Frediano Ziglio <freddy77@gmail.com>
Acked-by: Jakub Janků <jjanku@redhat.com>

Frediano Ziglio authored Mar 18, 2020 and Frediano Ziglio committed Apr 28, 2020

Add some settings to both MingW and MSVC to more strongly force
static libraries linking.

Signed-off-by: Frediano Ziglio <freddy77@gmail.com>

Frediano Ziglio authored Dec 14, 2019 and Frediano Ziglio committed Apr 28, 2020

On Windows beside the various single executables like Linux there's
a single "magick" executable you can use specifying what you want
to do.
Having a single executable avoids the trick to fix "convert" problem
and is easier to port, you just have to copy the single executable.

Signed-off-by: Frediano Ziglio <freddy77@gmail.com>

Frediano Ziglio authored Mar 18, 2020 and Frediano Ziglio committed Apr 28, 2020

That function does also more checks on the message.

Signed-off-by: Frediano Ziglio <fziglio@redhat.com>
Acked-by: Jakub Janků <jjanku@redhat.com>

Frediano Ziglio authored Dec 05, 2019 and Frediano Ziglio committed Apr 24, 2020

Allows to easily change the size if needed

Signed-off-by: Frediano Ziglio <fziglio@redhat.com>

Frediano Ziglio authored Mar 18, 2020 and Frediano Ziglio committed Apr 24, 2020

Signed-off-by: Frediano Ziglio <fziglio@redhat.com>

Frediano Ziglio authored Mar 18, 2020 and Frediano Ziglio committed Apr 24, 2020

Use specific VD_AGENT_FILE_XFER_STATUS_SESSION_LOCKED error.

Signed-off-by: Frediano Ziglio <fziglio@redhat.com>

Frediano Ziglio authored Mar 18, 2020 and Frediano Ziglio committed Apr 24, 2020

Reuse AgentFileXferStatusMessageFull and agent_prepare_filexfer_status

Signed-off-by: Frediano Ziglio <fziglio@redhat.com>

Frediano Ziglio authored Mar 18, 2020 and Frediano Ziglio committed Apr 24, 2020

Allows these utilities to be used in the code.

Signed-off-by: Frediano Ziglio <fziglio@redhat.com>

The EXTRA_DIST part in Makefile.am is needed as spice-protocol
removed support for Autoconf.
We don't need anymore "ignore=untracked" in the submodule as
we are not going to add or modify files anymore.

Signed-off-by: Frediano Ziglio <fziglio@redhat.com>

Reduce CI resource usage using a single job instead of 2.
The project is pretty small and the setup of the 2 jobs is pretty
long compared to the build so using a single job (we used the same
container image for both) reduce CI resource usage.

Signed-off-by: Frediano Ziglio <fziglio@redhat.com>
Acked-by: Victor Toso <victortoso@redhat.com>

Force sync and update of all git submodules.
Do not install packaged spice-protocol, we are using submodule.

Signed-off-by: Frediano Ziglio <fziglio@redhat.com>
Acked-by: Victor Toso <victortoso@redhat.com>

Revert "try to remove other bugs", commit
57266085.
Revert "try to fix previous", commit
8e403770.
Revert "attempt to fix more warnings!", commit
66b6933a

.

I put by mistake on the MR due to some automatic scripts.
Their state are pretty experimental.

Signed-off-by: Frediano Ziglio <fziglio@redhat.com>

Avoids:

warning C4267: 'initializing': conversion from 'size_t' to 'DWORD', possible loss of data

Value won't never be that huge to cause overflow (we are reading a string
in a static buffer, we don't expect an encyclopedia).

Signed-off-by: Frediano Ziglio <fziglio@redhat.com>

Avoids:

warning C4267: '=': conversion from 'size_t' to 'int', possible loss of data

Signed-off-by: Frediano Ziglio <fziglio@redhat.com>

test-shell script is needed for "make check".

Signed-off-by: Frediano Ziglio <fziglio@redhat.com>
Acked-by: Uri Lublin <uril@redhat.com>

Uri Lublin authored Mar 04, 2020 and Frediano Ziglio committed Mar 19, 2020

Signed-off-by: Uri Lublin <uril@redhat.com>
Acked-by: Frediano Ziglio <fziglio@redhat.com>

Uri Lublin authored Dec 23, 2019 and Frediano Ziglio committed Mar 19, 2020

This will help with making a release.

spice-protocol's .gitignore is generated and not committed,
so after running ./autogen.sh (autoreconf) git thinks
spice-protocol is dirty (just because of generated files).

Signed-off-by: Uri Lublin <uril@redhat.com>
Acked-by: Frediano Ziglio <fziglio@redhat.com>