1. 24 Mar, 2022 2 commits
    • Frediano Ziglio's avatar
      ci: Workaround a bug in Fedora 35 mingw64-make script · 4a1e9a03
      Frediano Ziglio authored
      
      
      mingw64-make is a bash script that wraps make command passing
      additional arguments and setup in order to cross compiler for
      MingW (to target Windows).
      In Fedora 35 the script passes the arguments we provide
      twice. So if we pass (like in this case)
      "LOG_COMPILE=wine -C server check" the final make command will
      receive
      "LOG_COMPILE=wine -C server check LOG_COMPILE=wine -C server check"
      arguments.
      This for some arguments it's not a problem but passing "-C <dir>"
      twice causes make to attempt to change directory twice.
      This causes a
      
          make: *** server: No such file or directory.  Stop.
      
      error. Use cd command before invoking mingw64-make to avoid
      having to pass "-C" option.
      Signed-off-by: Frediano Ziglio's avatarFrediano Ziglio <freddy77@gmail.com>
      4a1e9a03
    • Frediano Ziglio's avatar
      ci: Set WINEPATH before executing tests for Windows · a73b82fc
      Frediano Ziglio authored
      
      
      Without it on Fedora 35 Wine is not able to find DLLs installed
      on the system.
      Signed-off-by: Frediano Ziglio's avatarFrediano Ziglio <freddy77@gmail.com>
      a73b82fc
  2. 23 Mar, 2022 3 commits
  3. 21 Mar, 2022 1 commit
    • Christian Ehrhardt's avatar
      Revert "reds: start QXL devices if VM is running" (fix race) · ab9ad87c
      Christian Ehrhardt authored
      Due to reds->vm_running being initialized to TRUE (since c302e12c
      "spice.h: add entries for tracking vm state") the assumption in c23cbd6f
      "reds: start QXL devices if VM is running" was wrong and we can't check
      on vm_running until that initialization isn't on TRUE (it is that way for
      backward compatibility).
      
      Without this revert on qemu initializing spice we will have the
      display_init side of qemu not yet ready and therefore respond badly when
      spice sends an event as reaction to `red_qxl_start`:
         "qxl_send_events: spice-server bug: guest stopped, ignoring."
      
      At least with qemu > v2.0 as a spice consumer is not showing issues as
      `red_qxl_start` will be called just after the qemu side is ready
      `qemu_spice_display_start` -> `spice_server_vm_start`  ... `red_qxl_start`.
      
      Therefore - for now to avoid the current regression - Revert c23cbd6f
      "reds: start QXL devices if VM is running" until that old (2012)
      initialization is updated (probably an ABI change and therefore taking
      some time).
      
      Fixes: #64
      
      This reverts commit c23cbd6f.
      ab9ad87c
  4. 29 Jan, 2022 1 commit
    • Frediano Ziglio's avatar
      ci: Fix compile error using new GStreamer library · b24e2ea6
      Frediano Ziglio authored
      
      
      Using Fedora 35 the compilation fails due to this warning:
      
          ../server/gstreamer-encoder.c: In function 'create_pipeline':
          ../server/gstreamer-encoder.c:994:5: error: braces around scalar initializer [-Werror]
           994 |     GstAppSinkCallbacks appsink_cbs = {NULL, NULL, &new_sample, {NULL}};
               |     ^~~~~~~~~~~~~~~~~~~
          ../server/gstreamer-encoder.c:994:5: note: (near initialization for 'appsink_cbs.new_event')
          ../server/gstreamer-encoder.c:994:5: error: missing initializer for field '_gst_reserved' of 'GstAppSinkCallbacks' [-Werror=missing-field-initializers]
          In file included from ../server/gstreamer-encoder.c:26:
          /usr/include/gstreamer-1.0/gst/app/gstappsink.h:81:16: note: '_gst_reserved' declared here
             81 |   gpointer     _gst_reserved[GST_PADDING - 1];
                |                ^~~~~~~~~~~~~
          cc1: all warnings being treated as errors
      
      Change structure initialisation to avoid the warning.
      The same syntax is already used in server/tests/test-gst.cpp.
      Signed-off-by: Frediano Ziglio's avatarFrediano Ziglio <freddy77@gmail.com>
      b24e2ea6
  5. 04 Jan, 2022 1 commit
  6. 11 Nov, 2021 1 commit
  7. 28 Sep, 2021 1 commit
  8. 26 Aug, 2021 4 commits
  9. 23 Aug, 2021 1 commit
  10. 07 Aug, 2021 16 commits
  11. 04 Aug, 2021 7 commits
  12. 14 Jun, 2021 2 commits