1. 25 Mar, 2020 1 commit
  2. 24 Mar, 2020 3 commits
  3. 23 Mar, 2020 7 commits
  4. 20 Mar, 2020 2 commits
    • Frediano Ziglio's avatar
      Declare virtual destructor to avoid a warning · ae67c778
      Frediano Ziglio authored
      GCC gives this warning:
      
      .../plugin.hpp:103:7: warning: ‘class spice::streaming_agent::Agent’ has virtual functions and accessible non-virtual destructor [-Wnon-virtual-dtor]
      103 | class Agent
          |       ^~~~~
      
      Although in this case is not an issue (the class is planned to be
      inherited only once and destructor not be called from base class)
      add virtual destructor. Declare protected to avoid plugins to call
      delete on the Agent.
      
      The destructor is declared at the end to avoid changing ABI.
      Currently we supported and released only GCC compiler where the
      vtable has this layout:
      
      Without the patch:
      
      RELOCATION RECORDS FOR [.data.rel.ro.local._ZTVN5spice15streaming_agent13ConcreteAgentE]:
      OFFSET           TYPE              VALUE
      0000000000000008 R_X86_64_64       typeinfo for spice::streaming_agent::ConcreteAgent
      0000000000000010 R_X86_64_64       spice::streaming_agent::ConcreteAgent::Register(std::shared_ptr<spice::streaming_agent::Plugin> const&)
      0000000000000018 R_X86_64_64       spice::streaming_agent::ConcreteAgent::Options() const
      0000000000000020 R_X86_64_64       spice::streaming_agent::ConcreteAgent::LogStat(char const*, ...)
      
      Destructor at the beginning of the class:
      
      RELOCATION RECORDS FOR [.data.rel.ro.local._ZTVN5spice15streaming_agent13ConcreteAgentE]:
      OFFSET           TYPE              VALUE
      0000000000000008 R_X86_64_64       typeinfo for spice::streaming_agent::ConcreteAgent
      0000000000000010 R_X86_64_64       spice::streaming_agent::ConcreteAgent::~ConcreteAgent()
      0000000000000018 R_X86_64_64       spice::streaming_agent::ConcreteAgent::~ConcreteAgent()
      0000000000000020 R_X86_64_64       spice::streaming_agent::ConcreteAgent::Register(std::shared_ptr<spice::streaming_agent::Plugin> const&)
      0000000000000028 R_X86_64_64       spice::streaming_agent::ConcreteAgent::Options() const
      0000000000000030 R_X86_64_64       spice::streaming_agent::ConcreteAgent::LogStat(char const*, ...)
      
      Destructor at the end of the class:
      
      RELOCATION RECORDS FOR [.data.rel.ro.local._ZTVN5spice15streaming_agent13ConcreteAgentE]:
      OFFSET           TYPE              VALUE
      0000000000000008 R_X86_64_64       typeinfo for spice::streaming_agent::ConcreteAgent
      0000000000000010 R_X86_64_64       spice::streaming_agent::ConcreteAgent::Register(std::shared_ptr<spice::streaming_agent::Plugin> const&)
      0000000000000018 R_X86_64_64       spice::streaming_agent::ConcreteAgent::Options() const
      0000000000000020 R_X86_64_64       spice::streaming_agent::ConcreteAgent::LogStat(char const*, ...)
      0000000000000028 R_X86_64_64       spice::streaming_agent::ConcreteAgent::~ConcreteAgent()
      0000000000000030 R_X86_64_64       spice::streaming_agent::ConcreteAgent::~ConcreteAgent()
      
      As you can see offsets do not change declaring destructor at the end
      while they change putting declaration at the beginning.
      Signed-off-by: Frediano Ziglio's avatarFrediano Ziglio <fziglio@redhat.com>
      Acked-by: Kevin Pouget's avatarKevin Pouget <kpouget@redhat.com>
      ae67c778
    • Frediano Ziglio's avatar
      build: Merge configurations from spice-common · 7570624f
      Frediano Ziglio authored
      This is necessary otherwise the files we include from spice-common
      won't find the correct configuration.
      Signed-off-by: Frediano Ziglio's avatarFrediano Ziglio <fziglio@redhat.com>
      Acked-by: Kevin Pouget's avatarKevin Pouget <kpouget@redhat.com>
      7570624f
  5. 19 Mar, 2020 4 commits
  6. 18 Mar, 2020 3 commits
  7. 04 Mar, 2020 1 commit
  8. 20 Feb, 2020 2 commits
  9. 18 Feb, 2020 1 commit
  10. 16 Feb, 2020 1 commit
  11. 22 Jan, 2020 1 commit
  12. 13 Jan, 2020 1 commit
    • Uri Lublin's avatar
      Cursor: ignore big cursors · 1f80431a
      Uri Lublin authored
      Return early if the cursor received from X is too big.
      
      This fixes a covscan error: "sign_extension: Suspicious implicit sign extension":
        "cursor->width" with type "unsigned short" (16 bits, unsigned) is promoted in
        "cursor->width * cursor->height" to type "int" (32 bits, signed), then sign-extended
        to type "unsigned long" (64 bits, unsigned). If "cursor->width * cursor->height" is
        greater than 0x7FFFFFFF, the upper bits of the result will all be 1.
      Signed-off-by: Uri Lublin's avatarUri Lublin <uril@redhat.com>
      Acked-by: Frediano Ziglio's avatarFrediano Ziglio <fziglio@redhat.com>
      1f80431a
  13. 03 Dec, 2019 1 commit
  14. 17 Nov, 2019 3 commits
  15. 12 Nov, 2019 1 commit
  16. 22 Sep, 2019 1 commit
  17. 13 Aug, 2019 1 commit
  18. 11 Aug, 2019 1 commit
  19. 06 Aug, 2019 3 commits
  20. 22 Jul, 2019 1 commit
  21. 02 Jul, 2019 1 commit