Commit 36410d58 authored by Snir Sheriber's avatar Snir Sheriber
Browse files

gst-plugin: Changing framerate crash when ximagesrc is used

When XLIB_CAPTURE is set to 0 and framerate is set to anything
other than 25 streaming-agent crashes

This is a regression caused by e0cf764b

Fixing it is done by adding the framerate value to conversion caps
Signed-off-by: Snir Sheriber's avatarSnir Sheriber <>
Acked-by: Frediano Ziglio's avatarFrediano Ziglio <>
parent 1f76210a
Pipeline #77860 failed with stage
in 2 minutes and 19 seconds
......@@ -237,7 +237,10 @@ void GstreamerFrameCapture::pipeline_init(const GstreamerEncoderSettings &settin
gst_bin_add(bin, sink);
GstCapsUPtr caps(gst_caps_from_string("video/x-raw(ANY)"));
link = gst_element_link(capture.get(), convert.get()) &&
GstCapsUPtr convert_caps(gst_caps_new_simple("video/x-raw",
"framerate", GST_TYPE_FRACTION, settings.fps, 1,
link = gst_element_link_filtered(capture.get(), convert.get(), convert_caps.get()) &&
gst_element_link_filtered(convert.get(), encoder.get(), caps.get()) &&
gst_element_link_filtered(encoder.get(), sink.get(), sink_caps.get());
if (!link) {
Markdown is supported
0% or .
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment