1. 14 Oct, 2019 1 commit
  2. 30 Sep, 2019 1 commit
  3. 27 Sep, 2019 6 commits
  4. 23 Sep, 2019 9 commits
  5. 19 Sep, 2019 2 commits
  6. 09 Sep, 2019 4 commits
  7. 05 Sep, 2019 6 commits
    • Frediano Ziglio's avatar
      usb-backend: SpiceUsbredirChannel is not opaque anymore · f361d172
      Frediano Ziglio authored
      Use specific type in spice_usb_backend_channel_new and
      specific name instead of "user_data" field.
      Signed-off-by: Frediano Ziglio's avatarFrediano Ziglio <fziglio@redhat.com>
      Acked-by: default avatarVictor Toso <victortoso@redhat.com>
      f361d172
    • Frediano Ziglio's avatar
      channel-usbredir: Rename spice_usbredir_write_callback · d9ec1ce3
      Frediano Ziglio authored
      Remove "_callback" suffix.
      The function is called directly, no much reasons to keep that
      suffix.
      Signed-off-by: Frediano Ziglio's avatarFrediano Ziglio <fziglio@redhat.com>
      Acked-by: default avatarVictor Toso <victortoso@redhat.com>
      d9ec1ce3
    • Victor Toso's avatar
      main: code style on main_migrate_connect() · a8cf5ff5
      Victor Toso authored
      1) Make one argument per line, instead of 1, 2, 1
      2) Use session variable that already exists
      3) Don't cast again to SpiceChannel
      Signed-off-by: default avatarVictor Toso <victortoso@redhat.com>
      Acked-by: Frediano Ziglio's avatarFrediano Ziglio <fziglio@redhat.com>
      a8cf5ff5
    • Victor Toso's avatar
      main: migration: check return value to count channels · d77b2db8
      Victor Toso authored
      Although spice_channel_connect() works in idle, if it returns false
      it'll not emit any signal further and we would be counting a
      'connected' channel that wouldn't be emitting anything.
      
      As other callbacks take this in consideration, we should only
      increment the counter if we reached spice-channel::connect_delayed()
      callback.
      Signed-off-by: default avatarVictor Toso <victortoso@redhat.com>
      Acked-by: Frediano Ziglio's avatarFrediano Ziglio <fziglio@redhat.com>
      d77b2db8
    • Victor Toso's avatar
      main: return void on migrate_channel_connect() · 6538d15b
      Victor Toso authored
      The migration process would happen in idle, so the process only fails
      at a later time. No call to migrate_channel_connect() is actually
      checking the return value.
      Signed-off-by: default avatarVictor Toso <victortoso@redhat.com>
      Acked-by: Frediano Ziglio's avatarFrediano Ziglio <fziglio@redhat.com>
      6538d15b
    • Victor Toso's avatar
      spice-gstaudio: fix GTask leak on query for volume · 4b9d56b7
      Victor Toso authored
       > 184 bytes in 1 blocks are definitely lost in loss record 12,668 of 14,231
       >    at 0x483880B: malloc (vg_replace_malloc.c:309)
       >    by 0x4A64C98: g_malloc (in /usr/lib64/libglib-2.0.so.0.6000.6)
       >    by 0x4A7CFB5: g_slice_alloc (in /usr/lib64/libglib-2.0.so.0.6000.6)
       >    by 0x4A7D5DD: g_slice_alloc0 (in /usr/lib64/libglib-2.0.so.0.6000.6)
       >    by 0x4D3E061: g_type_create_instance (in /usr/lib64/libgobject-2.0.so.0.6000.6)
       >    by 0x4D2042C: ??? (in /usr/lib64/libgobject-2.0.so.0.6000.6)
       >    by 0x4D21B14: g_object_new_with_properties (in /usr/lib64/libgobject-2.0.so.0.6000.6)
       >    by 0x4D226C0: g_object_new (in /usr/lib64/libgobject-2.0.so.0.6000.6)
       >    by 0x4BE0FB8: g_task_new (in /usr/lib64/libgio-2.0.so.0.6000.6)
       >    by 0x48EDFCB: spice_gstaudio_get_record_volume_info_async (spice-gstaudio.c:679)
       >    by 0x48C2A4F: spice_audio_get_record_volume_info_async (spice-audio.c:212)
       >    by 0x48B2F00: agent_sync_audio_record (channel-main.c:1285)
       >
       > 240 (184 direct, 56 indirect) bytes in 1 blocks are definitely lost in loss record 12,889 of 14,231
       >    at 0x483880B: malloc (vg_replace_malloc.c:309)
       >    by 0x4A64C98: g_malloc (in /usr/lib64/libglib-2.0.so.0.6000.6)
       >    by 0x4A7CFB5: g_slice_alloc (in /usr/lib64/libglib-2.0.so.0.6000.6)
       >    by 0x4A7D5DD: g_slice_alloc0 (in /usr/lib64/libglib-2.0.so.0.6000.6)
       >    by 0x4D3E061: g_type_create_instance (in /usr/lib64/libgobject-2.0.so.0.6000.6)
       >    by 0x4D2042C: ??? (in /usr/lib64/libgobject-2.0.so.0.6000.6)
       >    by 0x4D21B14: g_object_new_with_properties (in /usr/lib64/libgobject-2.0.so.0.6000.6)
       >    by 0x4D226C0: g_object_new (in /usr/lib64/libgobject-2.0.so.0.6000.6)
       >    by 0x4BE0FB8: g_task_new (in /usr/lib64/libgio-2.0.so.0.6000.6)
       >    by 0x48EDAF9: spice_gstaudio_get_playback_volume_info_async (spice-gstaudio.c:597)
       >    by 0x48C2967: spice_audio_get_playback_volume_info_async (spice-audio.c:189)
       >    by 0x48B2C33: agent_sync_audio_playback (channel-main.c:1229)
      Signed-off-by: default avatarVictor Toso <victortoso@redhat.com>
      Acked-by: default avatarEduardo Lima (Etrunko) <etrunko@redhat.com>
      4b9d56b7
  8. 03 Sep, 2019 1 commit
  9. 02 Sep, 2019 3 commits
  10. 29 Aug, 2019 1 commit
    • Frediano Ziglio's avatar
      build: Fix compatibility with Meson 0.49 · aed7c51a
      Frediano Ziglio authored
      The "install" argument for configure_file is available since 0.50.
      However this is already "false" if "install_dir" is not provided.
      
      Update also spice-common submodule to import a similar fix for
      spice-common module. This brings in the following changes:
      
      Frediano Ziglio (10):
            gitignore: Ignore auto generated generated_messages.h file
            Do not check for HAVE_CONFIG_H
            build: Remove unused git-version-gen file
            recorder: Update
            build: Disable Celt support by default
            codegen: Use has_end_attr instead of has_attr("end")
            codegen: Exit with error on error generating C structures
            protocol: Removed unneeded type specifications
            codegen: Add a check for C structure fields
            meson: Remove "install" argument from configure_file
      
      Uri Lublin (2):
            ptypes.py: remove useless condition member != None
            test-marshallers.proto: ArrayMessage: make space for name
      Signed-off-by: Frediano Ziglio's avatarFrediano Ziglio <fziglio@redhat.com>
      Acked-by: default avatarEduardo Lima (Etrunko) <etrunko@redhat.com>
      aed7c51a
  11. 27 Aug, 2019 3 commits
  12. 26 Aug, 2019 1 commit
  13. 22 Aug, 2019 2 commits