hexchain authored Jul 10, 2020 and Frediano Ziglio committed Aug 19, 2020

Signed-off-by: Haochen Tong <i@hexchain.org>
Acked-by: Frediano Ziglio <fziglio@redhat.com>

hexchain authored Jul 08, 2020 and Frediano Ziglio committed Aug 19, 2020

GDK scales hotspot coordinates using screen scale factor on X11. We need
to undo this to get the correct hotspot behavior, otherwise mouse
selection becomes very inaccurate and difficult in the guest.

See [1].

[1] https://gitlab.gnome.org/GNOME/gtk/-/blob/3.24.21/gdk/x11/gdkcursor-x11.c#L556-557

Signed-off-by: Haochen Tong <i@hexchain.org>
Acked-by: Frediano Ziglio <fziglio@redhat.com>

hexchain authored Jul 08, 2020 and Frediano Ziglio committed Aug 19, 2020

Fixes #127

.
Signed-off-by: Haochen Tong <i@hexchain.org>
Acked-by: Frediano Ziglio <fziglio@redhat.com>

hexchain authored Jul 08, 2020 and Frediano Ziglio committed Aug 19, 2020

Signed-off-by: Haochen Tong <i@hexchain.org>
Acked-by: Frediano Ziglio <fziglio@redhat.com>

hexchain authored Jul 08, 2020 and Frediano Ziglio committed Aug 19, 2020

On HiDPI displays, guest screen used to be blurry because the screen
size is smaller than the widget size, and is scaled up. This patch fixes
that by considering scale factor when calculating geometry.
Signed-off-by: Haochen Tong <i@hexchain.org>
Acked-by: Frediano Ziglio <fziglio@redhat.com>

Signed-off-by: Frediano Ziglio <freddy77@gmail.com>
Acked-by: Marc-André Lureau <marcandre.lureau@redhat.com>

container_of is already implemented using spice macros.
Signed-off-by: Frediano Ziglio <freddy77@gmail.com>
Acked-by: Marc-André Lureau <marcandre.lureau@redhat.com>

Signed-off-by: Frediano Ziglio <freddy77@gmail.com>
Acked-by: Marc-André Lureau <marcandre.lureau@redhat.com>

Using a single "caller" global does not allow to store multiple
coroutines so use "caller" inside coroutine structure.
Also correctly set the current coroutine returning in coroutine_swap.
Signed-off-by: Frediano Ziglio <freddy77@gmail.com>
Acked-by: Marc-André Lureau <marcandre.lureau@redhat.com>

Not used and implemented in different ways by the various
coroutine implementations
Signed-off-by: Frediano Ziglio <freddy77@gmail.com>
Acked-by: Marc-André Lureau <marcandre.lureau@redhat.com>

Signed-off-by: Frediano Ziglio <freddy77@gmail.com>
Acked-by: Marc-André Lureau <marcandre.lureau@redhat.com>

Only used by different coroutine implementations
Signed-off-by: Frediano Ziglio <freddy77@gmail.com>
Acked-by: Marc-André Lureau <marcandre.lureau@redhat.com>

The function never returns a NULL value
Signed-off-by: Frediano Ziglio <freddy77@gmail.com>
Acked-by: Marc-André Lureau <marcandre.lureau@redhat.com>

Not necessary from Glib 2.32 for static allocated conditions.
Signed-off-by: Frediano Ziglio <freddy77@gmail.com>
Acked-by: Marc-André Lureau <marcandre.lureau@redhat.com>

Signed-off-by: Frediano Ziglio <freddy77@gmail.com>
Acked-by: Marc-André Lureau <marcandre.lureau@redhat.com>

Do not pass always G_IO_OUT. In case SSL_connect is waiting for
data and error was SSL_ERROR_WANT_READ instead of SSL_ERROR_WANT_WRITE
this was creating a tight loop repeatedly calling SSL_connect till
data arrived.
Note that G_IO_ERR and G_IO_HUP are always detected so no need to
add them.
Signed-off-by: Frediano Ziglio <freddy77@gmail.com>

Code was duplicate in 2 places.
The or operation ("|") was not necessary as condition was reset to
0 some lines above in both functions.
Signed-off-by: Frediano Ziglio <freddy77@gmail.com>

These structures contain only bytes, no need for this attribute.
Signed-off-by: Frediano Ziglio <fziglio@redhat.com>

OldRedMigrationBegin is not used. Last usage removed in

  commit f944ad69

    More cleanup for old protocol support

    Support for protocol version 1 was dropped in commit f77a1d50

.
Signed-off-by: Frediano Ziglio <freddy77@gmail.com>

Jakub Janků authored Jul 20, 2020 and Frediano Ziglio committed Jul 22, 2020

If we read 0 bytes from the phodav server,
the client connection was closed by the server.

In that case, remove the client immediately,
instead of waiting for the data to be written to the mux channel.

Fixes: https://lists.freedesktop.org/archives/spice-devel/2020-July/051765.html

I believe that the underlying issue, that is causing the described problems,
is that libsoup closes the connection after each request
although the webdav client wanted it to be persistant (keep-alive).

Filed an issue for libsoup:
https://gitlab.gnome.org/GNOME/libsoup/-/issues/195



Additionally, spice-webdavd does not close the connection
when it receives 0-size message for a given webdav client.

As a result, single webdav client can send multiple request using one
connection to spice-webdavd, but in spice-gtk for each request
a new client with the same id must be created.

This leads to basically a race condition when there's still the
client with the given id in the hash table, but the connection
was already closed by libsoup/phodav server. So a new client should
be started but the old closed one is used. The write op then
naturally fails with the following error and the request is lost:

    ../spice-gtk-0.38/src/channel-webdav.c:325 webdav-11:0: write failed: Stream is already closed

So check whether the output stream is closed before demuxing.

Also add some debug messages.
Signed-off-by: Jakub Janků <jjanku@redhat.com>
Acked-by: Frediano Ziglio <fziglio@redhat.com>

This is a follow-up to 228caca2 (!52)

85ed2684

 left some residues
in spice-session-priv.h, remove them.
Signed-off-by: Jakub Janků <jjanku@redhat.com>

Kevin Pouget authored May 19, 2020 and Frediano Ziglio committed May 23, 2020

When `build-aux/git-version-gen` is not able to find the project
version (no git tags and no `.tarball-version`), it returns 'UNKNOWN'
or 'UNKNOWN-dirty' (instead of the project version like
`0.38.28-d79b`).

This `UNKNOWN` value fails `meson build` command:

    src/meson.build:9:0: ERROR: Index 1 out of bounds of array of size 1.

With this patch, we set a default major/minor/micro value when the
actual version is unknown. This is the same as the `autoconf`
historical behavior.

See spice#41

.
Signed-off-by: Kevin Pouget <kpouget@redhat.com>
Acked-by: Frediano Ziglio <fziglio@redhat.com>

spice_session_get_webdav_magic() was removed by 85ed2684

,
but the declaration in spice-session-priv.h wasn't.
Signed-off-by: Jakub Janků <jjanku@redhat.com>

Frediano Ziglio authored Mar 19, 2020 and Frediano Ziglio committed May 15, 2020

Detect presence of detail on VD_AGENT_FILE_XFER_STATUS_ERROR and
if the error is supported give more detailed information, otherwise
fallback to the old generic error.
Signed-off-by: Frediano Ziglio <fziglio@redhat.com>
Acked-by: Victor Toso <victortoso@redhat.com>

Francesco Giudici authored Apr 20, 2020 and Frediano Ziglio committed May 11, 2020

We can now properly manage mouse pointer lock by using the wayland protocols.
Includes fix from Frediano Ziglio to manage switching from mouse in
server mode to client mode without releasing the pointer
(see fziglio/spice-gtk@c14b047e

)
Signed-off-by: Francesco Giudici <fgiudici@redhat.com>
Acked-by: Frediano Ziglio <fziglio@redhat.com>

Francesco Giudici authored Apr 20, 2020 and Frediano Ziglio committed May 11, 2020

This will be used later to couple it with relative mouse movement under
Wayland: we just get the mouse movement from the Wayland protocols
callback.
Signed-off-by: Francesco Giudici <fgiudici@redhat.com>
Acked-by: Frediano Ziglio <fziglio@redhat.com>

Francesco Giudici authored Mar 28, 2017 and Frediano Ziglio committed May 11, 2020

add utilities to lock the pointer to a window and to get relative mouse
movement in Wayland. This is made possible thanks to the wayland
protocols introduced in the previous commit.

Code freely taken and adapted from Christophe Fergeau branch:
https://gitlab.freedesktop.org/teuf/spice-gtk/-/tree/wayland

Signed-off-by: Francesco Giudici <fgiudici@redhat.com>
Acked-by: Frediano Ziglio <fziglio@redhat.com>

Francesco Giudici authored Feb 27, 2020 and Frediano Ziglio committed May 11, 2020

Generate wayland protocols: these will be used later for locking the
mouse pointer and getting relative mouse movements when using the mouse
in server mode in Wayland.
The meson build steps have been freely taken and adapted from Weston
source code:
https://gitlab.freedesktop.org/wayland/weston/-/blob/master/protocol/meson.build

Signed-off-by: Francesco Giudici <fgiudici@redhat.com>
Acked-by: Frediano Ziglio <fziglio@redhat.com>

Gilmar Santos Jr authored May 06, 2020 and Frediano Ziglio committed May 06, 2020

When SASL is in use, its buffer may contain remaining data from previously
received messages. The spice_channel_iterate_read should use it, even if c->in
socket is not readable.

Fixes: #126

Acked-by: Frediano Ziglio <fziglio@redhat.com>

The executable is not intended to be called by users.
Many distributions already relocate the executable to another
directory.
This fixes Gitlab issue #123

.
Signed-off-by: Frediano Ziglio <freddy77@gmail.com>
Acked-by: Francesco Giudici <fgiudici@redhat.com>

Frediano Ziglio authored Mar 19, 2020 and Frediano Ziglio committed Apr 26, 2020

Avoid one ternary operator inside another ternary operator.
Also remove no-C syntax.
Signed-off-by: Frediano Ziglio <fziglio@redhat.com>
Acked-by: Francesco Giudici <fgiudici@redhat.com>

Laurent Bigonville authored Apr 25, 2020 and Frediano Ziglio committed Apr 25, 2020

Fixes: #124

Acked-by: Frediano Ziglio <fziglio@redhat.com>

This allows SPICE common to request the right version.
Signed-off-by: Frediano Ziglio <freddy77@gmail.com>

This brings in the following changes:

Frediano Ziglio (3):
      helper-fuzzer-demarshallers: Add an helper for fuzzy testing demarshallers code
      Add helper code for agent messages
      agent: Fix incompatibility with Visual Studio compiler
Signed-off-by: Frediano Ziglio <freddy77@gmail.com>

This brings in the following changes:

Frediano Ziglio (1):
      build: Allows to request a greater SPICE protocol version
Signed-off-by: Frediano Ziglio <freddy77@gmail.com>

usbredir only supports little endian, using on big endian machine
won't work causing crashes.
Signed-off-by: Frediano Ziglio <freddy77@gmail.com>
Acked-by: Francesco Giudici <fgiudici@redhat.com>

Marc-André Lureau authored Apr 09, 2020 and Frediano Ziglio committed Apr 16, 2020

On file systems without capabilities attributes, drop capabilities at
runtime from the start.
Signed-off-by: Marc-André Lureau <marcandre.lureau@redhat.com>
Acked-by: Frediano Ziglio <fziglio@redhat.com>

Marc-André Lureau authored Apr 09, 2020 and Frediano Ziglio committed Apr 16, 2020

A privileged executable should operate with the least amount of
privileges possible. For spice-client-glib-usb-acl-helper, this is
CAP_FOWNER for acl_set_file() to succeed.
Signed-off-by: Marc-André Lureau <marcandre.lureau@redhat.com>
Acked-by: Frediano Ziglio <fziglio@redhat.com>

Marc-André Lureau authored Apr 09, 2020 and Frediano Ziglio committed Apr 09, 2020

It was released on 2011-03-03, and is available in old debian stable
and all distros we care about.
Signed-off-by: Marc-André Lureau <marcandre.lureau@redhat.com>
Acked-by: Frediano Ziglio <fziglio@redhat.com>

Marc-André Lureau authored Apr 09, 2020 and Frediano Ziglio committed Apr 09, 2020

emacs mode got removed with:
git ls-tree HEAD -r --name-only | xargs sed -i '/Mode: C/d'
Signed-off-by: Marc-André Lureau <marcandre.lureau@redhat.com>
Acked-by: Frediano Ziglio <fziglio@redhat.com>