1. 12 Feb, 2015 1 commit
  2. 06 Feb, 2015 3 commits
    • Marc-André Lureau's avatar
      webdav: fix checking for shared directory property · 744632f9
      Marc-André Lureau authored
      Trivial fix for 6163828e:
      Channel should be created if the shared-dir property is set.
      744632f9
    • Benjamin Gilbert's avatar
      Don't build libspice-client-gtk if configured --without-gtk · 08101d01
      Benjamin Gilbert authored
      libspice-client-glib is useful as a client library on platforms that
      don't support GTK.
      08101d01
    • Christophe Fergeau's avatar
      Update git submodule · 6631e262
      Christophe Fergeau authored
      This fixes build with mingw as well as lz4 support:
      
      3aad79d LZ4: Do not include arpa/inet.h in Windows builds
      9287e53 LZ4: Add support for 24bit pixman surfaces
      d167e2e LZ4: Fix the row alignment when it is not on a 32bit boundary
      f76fc28 LZ4: Decode the image format from the stream
      83c0d64 LZ4: Adjust reading the top_down flag
      6049db4 LZ4: Fix output buffer size
      ac26fd7 Remove redundant #if defined(SW_CANVAS_CACHE) || defined(SW_CANVAS_IMAGE_CACHE)
      062bf67 Remove unused 'invers' arg from canvas_get_*
      619b995 common: fix build with mingw
      862b9b1 build-sys: Move pixman check to m4 macro
      137b1a5 build-sys: Move opengl check to m4 macro
      f9e0a64 build-sys: Move opus check to m4 macro
      dd57d05 build-sys: Move celt check to m4 macro
      fb3fe22 build-sys: Move smartcard check to m4 macro
      df74a17 build-sys: Move posix checks to a separate m4 macro
      2f1ba3b build-sys: Add fallback for AS_VAR_APPEND
      2195369 build-sys: Small cleanup of AM_CPPFLAGS
      ed873a9 build-sys: Remove unused WITH_SMARTCARD conditional
      2da14b6 build-sys: Remove unused win32 check
      5bfa9ca build-sys: Remove unused X check
      268d3e3 Remove unused header file
      6631e262
  3. 29 Jan, 2015 9 commits
  4. 27 Jan, 2015 10 commits
  5. 23 Jan, 2015 1 commit
  6. 16 Jan, 2015 1 commit
  7. 07 Jan, 2015 1 commit
  8. 06 Jan, 2015 3 commits
  9. 22 Dec, 2014 1 commit
    • Marc-André Lureau's avatar
      usbredir: prevent crash when calling without host · 5b252b0f
      Marc-André Lureau authored
      Quite annoyingly, usbredir doesn't have public functions arguments
      preconditions, and will weirdly run the flush callback during
      initialization.
      
      With 201a8c2e change, the channel state is kept as it is when calling
      reset. This will result in the following crash that was avoided before
      thanks to a precondition on the channel to be ready. Adding a further
      precondition check on priv->host != NULL solves the following crash
      during reset():
      
      Program received signal SIGSEGV, Segmentation fault.
      usbredirhost_write_guest_data (host=0x0) at usbredirhost.c:868
      868                               return
      usbredirparser_do_write(host->parser);
      (gdb) bt
       #0  0x00007fffb2ed24d0 in usbredirhost_write_guest_data (host=0x0) at
       #usbredirhost.c:868
       #1  0x00007fffc81d463b in
       #usbredir_write_flush_callback (user_data=0x2d95250) at
       #channel-usbredir.c:469
       #2  0x00007fffb2ed23f9 in usbredirhost_open_full (usb_ctx=0x2baba70,
       #usb_dev_handle=0x0, log_func=<optimized out>,
       #read_guest_data_func=0x7fffc81d482c <usbredir_read_callback>,
       #write_guest_data_func=0x7fffc81d4952 <usbredir_write_callback>,
       #flush_writes_func=0x7fffc81d45c3 <usbredir_write_flush_callback>,
       #alloc_lock_func=0x7fffc81d49f1 <usbredir_alloc_lock>,
       #lock_func=0x7fffc81d4a41 <usbredir_lock_lock>,
       #unlock_func=0x7fffc81d4a86 <usbredir_unlock_lock>,
       #free_lock_func=0x7fffc81d4acb <usbredir_free_lock>,
       #func_priv=0x2d95250, version=0x7fffc8283dcf "spice-gtk
       #0.27.7-89db-dirty", verbose=4, flags=1) at usbredirhost.c:748
       #3  0x00007fffc81d3b22 in
       #spice_usbredir_channel_set_context (channel=0x2d95250
       #[SpiceUsbredirChannel], context=0x2baba70) at channel-usbredir.c:212
       #4  0x00007fffc81d37a9 in spice_usbredir_channel_reset (c=0x2d95250
       #[SpiceUsbredirChannel], migrating=0)
       at channel-usbredir.c:125
       #5  0x00007fffc81b7f8d in spice_channel_reset (channel=0x2d95250
       [SpiceUsbredirChannel], migrating=0)
       at spice-channel.c:2688
       #6  0x00007fffc81b8057 in channel_disconnect (channel=0x2d95250
       [SpiceUsbredirChannel]) at spice-channel.c:2706
       #7  0x00007fffc81b7559 in
       spice_channel_coroutine (data=0x2d95250) at spice-channel.c:2490
      5b252b0f
  10. 16 Dec, 2014 6 commits
    • Marc-André Lureau's avatar
      channel: clear channel error after auth error · 43fc4921
      Marc-André Lureau authored
      When entered authentication details are wrong, spice-gtk will reset
      channel error, which will result in the following warning:
      
      (remote-viewer:20753): GLib-WARNING **: GError set over the top of a
      previous GError or uninitialized memory.
      This indicates a bug in someone's code. You must ensure an error is NULL
      before it's set.
      
      Clear channel error after reporting authentication error.
      43fc4921
    • Marc-André Lureau's avatar
      channel: throw auth error when coroutine ends · 201a8c2e
      Marc-André Lureau authored
      It is common that clients attempt to reconnect during the
      SPICE_CHANNEL_ERROR_AUTH callback.  However, the channel must exit
      the coroutine first before reconnection can happen.
      201a8c2e
    • Marc-André Lureau's avatar
      channel: introduce SPICE_CHANNEL_STATE_RECONNECTING · 9969d042
      Marc-André Lureau authored
      Add a new state that permits reconnection, because it's < CONNECTING.
      It also simplifies some code by removing unneeded variables in
      spice_channel_coroutine(): the channel.tls and session.protocol version
      properties are already modified during initial connection steps.
      9969d042
    • Marc-André Lureau's avatar
      channel: do not enter channel iterate on early error · 14ce8b8d
      Marc-André Lureau authored
      There is no need to enter channel_iterate() if we found an early
      connection steps error.
      14ce8b8d
    • Marc-André Lureau's avatar
      channel: factorize failed authentication · 21acda1c
      Marc-André Lureau authored
      There are a few things that should be common to all wrong authentication
      cases. Let's put them all in the same function.
      21acda1c
    • Marc-André Lureau's avatar
      session: keep main channel on reconnect · 6b475802
      Marc-André Lureau authored
      For legacy reasons, spice-gtk should keep at least one channel in the
      session when reconnecting (clients may decide that the session is
      disconnected when all channels are gone). The most obvious is to
      keep and reuse the main channel.
      6b475802
  11. 11 Dec, 2014 2 commits
  12. 05 Dec, 2014 1 commit
  13. 03 Dec, 2014 1 commit