aggregator: Deactivate pad before removing it from the element

Otherwise we might have a pad floating around that is still activated,
or even finalize a pad that is still activated.
31 jobs for aggregator-deactivate-before-remove in 113 minutes and 39 seconds (queued for 11 seconds)
latest
Status Job ID Name Coverage
  Preparation
passed #817974
gst indent

00:00:18

passed #817973
manifest

00:00:38

 
  Build
passed #817984
build cerbero cross-android universal

00:09:17

manual #817988
gst-ios-12.2 allowed to fail manual
build cerbero cross-ios universal
passed #817985
build cerbero cross win32

00:04:46

passed #817986
build cerbero cross win64

00:02:48

passed #817983
build cerbero fedora x86_64

00:05:14

passed #817987
gst-macos-10.14
build cerbero macos x86_64

00:07:04

passed #817979
build clang fedora x86_64

00:04:54

passed #817975
build fedora x86_64

00:04:14

passed #817982
docker windows 1607
build msys2

00:11:49

passed #817976
build nodebug fedora x86_64

00:03:00

passed #817977
build static fedora x86_64

00:07:04

passed #817978
build static nodebug fedora x86_64

00:05:00

passed #817980
docker windows 1607
build vs2017 amd64

00:10:29

passed #817981
docker windows 1607
build vs2017 x86

00:10:02

 
  Test
failed #820750
check fedora

00:05:00

passed #817990
integration testsuites fedora

00:38:16

failed #820749
valgrind bad

00:12:21

failed #820748
valgrind base

01:06:10

failed #820747
valgrind core

00:11:38

passed #817996
valgrind ges

00:18:19

passed #817993
valgrind good

00:10:44

passed #817994
valgrind ugly

00:02:46

failed #817989
check fedora

00:07:21

failed #817995
valgrind bad

00:22:04

failed #817992
valgrind base

01:05:57

failed #817991
valgrind core

00:15:10

 
  Integrate
passed #817997
cross-android universal examples

00:08:17

skipped #817999
gst-ios-12.2 allowed to fail manual
cross-ios universal examples
passed #817998
documentation

00:05:49

 
Name Stage Failure
failed
valgrind base Test
KeyboardInterrupt
Uploading artifacts...
gst-build/build/meson-logs/: found 2 matching files
validate-logs: found 1322 matching files

Uploading artifacts to coordinator... ok
id=820748 responseStatus=201 Created token=FkXuAaeb
Uploading artifacts...
validate-logs/*.xml: found 1 matching files

Uploading artifacts to coordinator... ok
id=820748 responseStatus=201 Created token=FkXuAaeb
ERROR: Job failed: exit code 1
failed
valgrind bad Test
           Total: 398
Uploading artifacts...
gst-build/build/meson-logs/: found 2 matching files
validate-logs: found 809 matching files

Uploading artifacts to coordinator... ok
id=820749 responseStatus=201 Created token=cYZG3kx8
Uploading artifacts...
validate-logs/*.xml: found 1 matching files

Uploading artifacts to coordinator... ok
id=820749 responseStatus=201 Created token=cYZG3kx8
ERROR: Job failed: exit code 1
failed
valgrind core Test
           Total: 851
Uploading artifacts...
gst-build/build/meson-logs/: found 2 matching files
validate-logs: found 1811 matching files

Uploading artifacts to coordinator... ok
id=820747 responseStatus=201 Created token=VSRU4EHa
Uploading artifacts...
validate-logs/*.xml: found 1 matching files

Uploading artifacts to coordinator... ok
id=820747 responseStatus=201 Created token=VSRU4EHa
ERROR: Job failed: exit code 1
failed
check fedora Test
KeyboardInterrupt
Uploading artifacts...
gst-build/build/meson-logs/: found 2 matching files
validate-logs: found 3185 matching files

Uploading artifacts to coordinator... ok
id=820750 responseStatus=201 Created token=pjke2oNP
Uploading artifacts...
WARNING: validate-logs/*.xml: no matching files
ERROR: No files to upload
ERROR: Job failed: exit code 1