Commit be4a6ba4 authored by Jan Schmidt's avatar Jan Schmidt

Revert "audioringbuffer: start ringbuffer if needed upon commit"

This reverts commit 13ee94ef.

Causes audio glitches at startup by starting to output segments
from the ringbuffer before it has been filled / fully prerolled.

https://bugzilla.gnome.org/show_bug.cgi?id=657076
parent d6d69ba1
......@@ -1470,18 +1470,6 @@ default_commit (GstAudioRingBuffer * buf, guint64 * sample,
g_return_val_if_fail (buf->memory != NULL, -1);
g_return_val_if_fail (data != NULL, -1);
/* writing stuff now, ensure running clock */
if (G_UNLIKELY (g_atomic_int_get (&buf->state) !=
GST_AUDIO_RING_BUFFER_STATE_STARTED)) {
/* see if we are allowed to start it */
if (G_UNLIKELY (g_atomic_int_get (&buf->may_start) == FALSE)) {
GST_DEBUG_OBJECT (buf, "not allowed to start");
} else {
GST_DEBUG_OBJECT (buf, "start!");
gst_audio_ring_buffer_start (buf);
}
}
need_reorder = buf->need_reorder;
channels = buf->spec.info.channels;
......
Markdown is supported
0% or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment