Skip to content
  • Sebastian Dröge's avatar
    audiobase{sink,src}: Don't hold the object lock while calling create_ringbuffer() vfunc · 9204caa2
    Sebastian Dröge authored and Tim-Philipp Müller's avatar Tim-Philipp Müller committed
    The implementation of that vfunc might want to use the object lock for
    something too. It's generally not a good idea to keep the object lock while
    calling any function implemented elsewhere.
    
    Also the ringbuffer can only be NULL at this point, remove a useless if block.
    
    And in the sink actually hold the object lock while setting the ringbuffer on
    the instance. Code accessing this is expected to use the object lock, so do it
    here ourselves too.
    9204caa2