Skip to content
  • Stian Selnes's avatar
    rtcpbuffer: Fix validation of packets with padding · 1586981b
    Stian Selnes authored and Sebastian Dröge's avatar Sebastian Dröge committed
    The padding (if any) is included in the length of the last packet, see
    RFC 3550.
    
    Section 6.4.1:
       padding (P): 1 bit
          If the padding bit is set, this individual RTCP packet contains
          some additional padding octets at the end which are not part of
          the control information but are included in the length field. The
          last octet of the padding is a count of how many padding octets
          should be ignored, including itself (it will be a multiple of
          four).
    
    Section A.2:
       *  The padding bit (P) should be zero for the first packet of a
          compound RTCP packet because padding should only be applied, if it
          is needed, to the last packet.
    
       *  The length fields of the individual RTCP packets must add up to
          the overall length of the compound RTCP packet as received.
    
    https://bugzilla.gnome.org/show_bug.cgi?id=751883
    1586981b