Commit dcea8baa authored by Sebastian Dröge's avatar Sebastian Dröge 🍵
Browse files

avcodecmap: Don't try converting channel layouts with more than 64 channels

We only support up to 64 channels in GStreamer with a specific layout so
it's safe to assume a NONE layout in this case.

Also the arrays of channel positions are allocated everywhere with 64
elements so don't try setting more than 64 to NONE as that will cause
stack corruptions and similar memory safety issues.

Thanks to Natalie Silvanovich for reporting this issue.

Fixes gstreamer/gst-libav#92

Part-of: <gstreamer/gst-libav!120>
parent 1d33d1c8
Pipeline #284299 passed with stages
in 29 minutes and 20 seconds
......@@ -102,7 +102,7 @@ gst_ffmpeg_channel_layout_to_gst (guint64 channel_layout, gint channels,
guint nchannels = 0;
gboolean none_layout = FALSE;
if (channel_layout == 0) {
if (channel_layout == 0 || channels > 64) {
nchannels = channels;
none_layout = TRUE;
} else {
......@@ -163,7 +163,7 @@ gst_ffmpeg_channel_layout_to_gst (guint64 channel_layout, gint channels,
} else {
guint i;
for (i = 0; i < nchannels; i++)
for (i = 0; i < nchannels && i < 64; i++)
pos[i] = GST_AUDIO_CHANNEL_POSITION_NONE;
}
}
......
Supports Markdown
0% or .
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment