1. 14 Jun, 2021 1 commit
  2. 27 May, 2020 1 commit
  3. 27 Jan, 2020 1 commit
  4. 22 Jan, 2020 1 commit
  5. 14 Jan, 2020 1 commit
  6. 22 Mar, 2019 1 commit
  7. 07 Mar, 2019 1 commit
  8. 07 Feb, 2019 4 commits
  9. 13 Jan, 2019 2 commits
  10. 29 Apr, 2017 1 commit
    • Marc-André Lureau's avatar
      slirp: tftp, copy sockaddr_size · 09c9b6a8
      Marc-André Lureau authored and Samuel Thibault's avatar Samuel Thibault committed
      ASAN detects an "unknown-crash" when running pxe-test:
      /ppc64/pxe/spapr-vlan: =================================================================
      ==7143==ERROR: AddressSanitizer: unknown-crash on address 0x7f6dcd298d30 at pc 0x55e22218830d bp 0x7f6dcd2989e0 sp 0x7f6dcd2989d0
      READ of size 128 at 0x7f6dcd298d30 thread T2
          #0 0x55e22218830c in tftp_session_allocate /home/elmarco/src/qq/slirp/tftp.c:73
          #1 0x55e22218a1f8 in tftp_handle_rrq /home/elmarco/src/qq/slirp/tftp.c:289
          #2 0x55e22218b54c in tftp_input /home/elmarco/src/qq/slirp/tftp.c:446
          #3 0x55e2221833fe in udp6_input /home/elmarco/src/qq/slirp/udp6.c:82
       0x55e222137b17 in ip6_input /home/elmarco/src/qq/slirp/ip6_input.c:67
      Address 0x7f6dcd298d30 is located in stack of thread T2 at offset 96 in frame
          #0 0x55e222182420 in udp6_input /home/elmarco/src/qq/slirp/udp6.c:13
        This frame has 3 object(s):
          [32, 48) '<unknown>'
          [96, 124) 'lhost' <== Memory access at offset 96 partially overflows this variable
          [160, 200) 'save_ip' <== Memory access at offset 96 partially underflows this variable
      The sockaddr_storage pointer is the sockaddr_in6 lhost on the
      stack. Copy only the source addr size.
      Signed-off-by: default avatarMarc-André Lureau <marcandre.lureau@redhat.com>
      Reviewed-by: Thomas Huth's avatarThomas Huth <thuth@redhat.com>
      Reviewed-by: philmd's avatarPhilippe Mathieu-Daudé <f4bug@amsat.org>
      Signed-off-by: Samuel Thibault's avatarSamuel Thibault <samuel.thibault@ens-lyon.org>
  11. 20 Dec, 2016 1 commit
  12. 12 Jul, 2016 1 commit
  13. 03 Jul, 2016 1 commit
  14. 22 Mar, 2016 1 commit
  15. 15 Mar, 2016 1 commit
  16. 04 Feb, 2016 2 commits
    • Peter Maydell's avatar
      slirp: Clean up includes · 424b19ef
      Peter Maydell authored
      Clean up includes so that osdep.h is included first and headers
      which it implies are not included manually.
      This commit was created with scripts/clean-includes.
      Signed-off-by: Peter Maydell's avatarPeter Maydell <peter.maydell@linaro.org>
      Message-id: 1454089805-5470-10-git-send-email-peter.maydell@linaro.org
    • Guillaume Subiron's avatar
      slirp: Factorizing address translation · a5dc81ef
      Guillaume Subiron authored
      This patch factorizes some duplicate code into a new function,
      sotranslate_out(). This function perform the address translation when a
      packet is transmitted to the host network. If the packet is destinated
      to the host, the loopback address is used, and if the packet is
      destinated to the virtual DNS, the real DNS address is used. This code
      is just a copy of the existent, but factorized and ready to manage the
      IPv6 case.
      On the same model, the major part of udp_output() code is moved into a
      new sotranslate_in(). This function is directly used in sorecvfrom(),
      like sotranslate_out() in sosendto().
      udp_output() becoming useless, it is removed and udp_output2() is
      renamed into udp_output(). This adds consistency with the udp6_output()
      function introduced by further patches.
      Lastly, this factorizes some duplicate code into sotranslate_accept(), which
      performs the address translation when a connection is established on the host
      for port forwarding: if it comes from localhost, the host virtual address is
      used instead.
      This prepares for IPv6 support.
      Signed-off-by: default avatarGuillaume Subiron <maethor@subiron.org>
      Signed-off-by: Samuel Thibault's avatarSamuel Thibault <samuel.thibault@ens-lyon.org>
      Reviewed-by: Thomas Huth's avatarThomas Huth <thuth@redhat.com>
      Signed-off-by: default avatarJason Wang <jasowang@redhat.com>
  17. 25 Mar, 2014 1 commit
  18. 13 Sep, 2012 4 commits
  19. 21 Aug, 2011 1 commit
  20. 25 Feb, 2011 1 commit
  21. 13 Jan, 2011 1 commit
  22. 25 Jul, 2010 1 commit
  23. 07 Mar, 2010 1 commit
  24. 13 Jan, 2010 1 commit
  25. 11 Jan, 2010 1 commit
    • Thomas Horsten's avatar
      Handle TFTP ERROR from client · 7a631901
      Thomas Horsten authored
      If a PXE client only wants to find out the size of a file, it will
      open the file and then abort the transfer by sending a TFTP ERROR packet.
      The ERROR packet should cause qemu to terminate the session. If not,
      the sessions will soon run out and cause timeouts in the client.
      Also, if a TFTP session already exists with same IP/UDP port, it
      should be terminated when a new RRQ is received, instead of creating a
      duplicate (which will never be used).
      A patch for gPXE to send the ERROR packet is also being submitted to
      gPXE. Together they resolve slowness/hanging when booting pxegrub from
      qemu's internal TFTP server. The patch from Milan Plzik to return
      after sending OACK is also required for a complete fix.
      Signed-off-by: default avatarThomas Horsten <thomas@horsten.com>
      Signed-off-by: default avatarMilan Plzik <milan.plzik@gmail.com>
      Signed-off-by: default avatarAnthony Liguori <aliguori@us.ibm.com>
  26. 29 Jun, 2009 7 commits