GitLab

Closes accountsservice/accountsservice#54

e9e4aaee changed the project name but didn't account for
meson.project_name() being used here.

ubuntu currently ships too old a meson, so
drop it for now.

The data contents for the enum related files are stored in the
build files.

This patch moves this information to template files to be used
along with glib-mkenums.

Recently accountsservice has been migrated from Intltool to
Gettext[0]. Due to this migration, and internal workings of
Gettext[1], instead of using `GETTEXT_PACKAGE`, the `PACKAGE`
definition was used. However, with meson, this is not necessary
anymore and only the `GETTEXT_PACKAGE` definition can be used.

[0] ab9933da
[1] https://www.gnu.org/software/autoconf/manual/gettext.html#configure_002eac

To avoid the burden of maintaining multiple build systems, this
patch removes autotools support.

GitLab CI configuration has also been updated to use meson.

meson is a build system focused on speed an ease of use, which
helps speeding up the software development. This patch adds meson
support along autotools.

Recent versions of Gettext are able to translate several formats
that are used in GNOME applications. This patch migrates from
Intltool to Gettext by using meson's i18n features.

Recent Gettext versions when used along with autotools, also make
use of `PACKAGE` and `VERSION` variables[0]. Due to this the domain
has been changed to use the value from `PACKAGE`.

[0] https://www.gnu.org/software/autoconf/manual/gettext.html#configure_002eac

`g_type_class_add_private` is the "old way" of doing things.

This commit updates the codebase to use `G_ADD_PRIVATE`,
`_get_instance_private ()`, `G_DEFINE_TYPE_WITH_PRIVATE`, etc.

accountsservice maintains a state file for some users, if those users
have selected a specific session or language.

There's no good way, at the moment, for an application to check if a
specific user has saved state.

This commit exports the Saved property on the User object.

Having a property called XSession in the API makes little
sense when wayland has taken the world by storm.

This commit adds new "Session" property without the "X" in the name,
and an additional property "SessionType" that can be either
"wayland" or "x11".

At the moment if logind can fail in two ways when
asking the session associated with the current pid:

1) ENOENT, the process isn't part of a registered session
2) ENODATA, the mechanism for checking which session a
process is registered with isn't working.

If we hit the second case then wefail loading the user manager
entirely.  This leads to the dbus proxy associated with a user
from loading and the user getting stuck with defaults like a
NULL xsession and systemaccount=TRUE

This commit changes the behavior for the second case to be
like the first. Namely, to accept there's no associated
session and carry on as best we can.

At the moment we set is-loaded on the user-manager
object as soon as we start fetching the seat, but
we should waiting until the seat is fetched, so
that can_switch() will return the correct value
if the caller waited until the loaded signal
to use it.

This commit changes the >= to > which I believe
was the original intention anyway.

https://bugs.freedesktop.org/show_bug.cgi?id=107298

The path prefix check can be circumvented by regular users by passing
relative path component like so:

$ dbus-send --system --print-reply --dest=org.freedesktop.Accounts \
        /org/freedesktop/Accounts/User1000 \
        org.freedesktop.Accounts.User.SetIconFile \
        string:/usr/share/../../tmp/test

This results in a user controlled path being stored in the
accountsservice. Clients of accountsservice may unwittingly trust this
path.

To fix that situation this commit canonicalizes the input path before
the prefix comparison.

Some small changes to patch by Ray Strode.

https://bugs.freedesktop.org/show_bug.cgi?id=107085

Some system accounts, e.g. sshd have no entries in /etc/shadow
because they are created prior to /etc/shadow and have no passwords.

Right now load_entries aborts iterating through /etc/passwd entries
if it fails to find the corresponding /etc/shadow entry, ignoring
all the users behind it, making those users missing from the gdm
login screen user list.

https://bugs.freedesktop.org/show_bug.cgi?id=106904

When user session type is wayland, act_user_is_logged_in can return TRUE
if user is logged in.

https://bugs.freedesktop.org/show_bug.cgi?id=106855

Right now we have code like:

 if (!refreshed_user || user_get_cached (user) && !user_get_cached (refreshed_user))

which gcc warns about because of missing parentheses.

This commit fixes it by adding brackets.

https://bugs.freedesktop.org/show_bug.cgi?id=106463

This reverts commit 27f4dbe3.

https://bugs.freedesktop.org/show_bug.cgi?id=106463

Right now we have code like:

 if (!refreshed_user || user_get_cached (user) && !user_get_cached (refreshed_user))

which gcc warns about because of missing parentheses.  Rather than
just add brackets, this commit moves the last bit into a separate boolean
for clarity.

https://bugs.freedesktop.org/show_bug.cgi?id=106463