Commit 89f4075f authored by Nicolas Dufresne's avatar Nicolas Dufresne

v4l2object: Don't open the device in get property

This is both racy and inefficient. This function is still missing some
locking which will be address in later patch.

https://bugzilla.gnome.org/show_bug.cgi?id=796185
parent 21cf943a
......@@ -720,15 +720,12 @@ gst_v4l2_object_get_property_helper (GstV4l2Object * v4l2object,
break;
case PROP_DEVICE_NAME:
{
const guchar *new = NULL;
const guchar *name = NULL;
if (GST_V4L2_IS_OPEN (v4l2object)) {
new = v4l2object->vcap.card;
} else if (gst_v4l2_open (v4l2object)) {
new = v4l2object->vcap.card;
gst_v4l2_close (v4l2object);
}
g_value_set_string (value, (gchar *) new);
if (GST_V4L2_IS_OPEN (v4l2object))
name = v4l2object->vcap.card;
g_value_set_string (value, (gchar *) name);
break;
}
case PROP_DEVICE_FD:
......
Markdown is supported
0% or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment