Skip to content
  • Mikhail Fludkov's avatar
    rtpsession: Fix on-feedback-rtcp race · 30661663
    Mikhail Fludkov authored and Sebastian Dröge's avatar Sebastian Dröge committed
    If there is an external source which is about to timeout and be removed
    from the source hashtable and we receive feedback RTCP packet with the
    media ssrc of the source, we unlock the session in
    rtp_session_process_feedback before emitting 'on-feedback-rtcp' signal
    allowing rtcp timer to kick in and grab the lock. It will get rid of
    the source and rtp_session_process_feedback will be left with RTPSource
    with ref count 0.
    
    The fix is to grab the ref to the RTPSource object in
    rtp_session_process_feedback.
    
    https://bugzilla.gnome.org/show_bug.cgi?id=795139
    30661663