Commit 30f6b63c authored by Sebastian Dröge's avatar Sebastian Dröge 🍵

videoaggregator: GstVideoConverter currently can't rescale and will assert

Leads to ugly assertions instead of properly erroring out:
CRITICAL **: gst_video_converter_new: assertion 'in_info->width == out_info->width' failed
parent 65ed8ecf
......@@ -450,8 +450,13 @@ gst_videoaggregator_update_converters (GstVideoAggregator * vagg)
GST_DEBUG_OBJECT (pad, "This pad will be converted from %d to %d",
GST_VIDEO_INFO_FORMAT (&best_info));
pad->priv->convert =
gst_video_converter_new (&pad->info, &best_info, NULL);
/* TODO: GstVideoConverter currently can't rescale! */
if (pad->info.width == best_info.width &&
pad->info.height == best_info.height &&
pad->info.par_n == best_info.par_n &&
pad->info.par_d == best_info.par_d)
pad->priv->convert =
gst_video_converter_new (&pad->info, &best_info, NULL);
pad->need_conversion_update = TRUE;
if (!pad->priv->convert) {
g_free (colorimetry);
Markdown is supported
0% or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment