Commit 16c185ba authored by Tim-Philipp Müller's avatar Tim-Philipp Müller 🐠
Browse files

libvisual: fix crashes and invalid writes in totem

This reverts part of "visual: enable commented out code again."
(commit 8222ba16).

The shader code does indeed look broken (or rather,
it makes assumptions that are not necessarily true here,
namly that pixel stride is 4, for example), which
makes totem very crashy and causes other weird behaviour.

Also see https://bugzilla.gnome.org/show_bug.cgi?id=683527
parent d4c1b160
......@@ -978,8 +978,10 @@ gst_audio_visualizer_chain (GstPad * pad, GstObject * parent,
GST_ERROR_OBJECT (scope, "render failed");
ret = GST_FLOW_ERROR;
} else {
/* run various post processing (shading and geometri transformation */
if (scope->shader) {
/* run various post processing (shading and geometric transformation) */
/* FIXME: SHADER assumes 32bpp */
if (scope->shader &&
GST_VIDEO_INFO_COMP_PSTRIDE (&scope->vinfo, 0) == 4) {
scope->shader (scope, &outframe, &scope->tempframe);
}
}
......
Markdown is supported
0% or .
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment