1. 06 Dec, 2018 1 commit
  2. 23 Oct, 2018 1 commit
  3. 21 Oct, 2018 1 commit
  4. 10 Oct, 2018 1 commit
    • Adam Reichold's avatar
      Remove usage of pragmas interface and implementation · 7f20ace4
      Adam Reichold authored
      GCC recommends not using them for a long time and its documentation says:
      > These #pragmas have been superceded as of GCC 2.7.2 by COMDAT support
      > and the “key method” heuristic mentioned in Vague Linkage.
      > Using them can actually cause your program to grow due to
      > unnecessary out-of-line copies of inline functions.
      
      Also nobody seems to set USE_GCC_PRAGMAS and sometimes they were
      guarded by just __GNUC__ which upsets Clang.
      7f20ace4
  5. 04 Oct, 2018 1 commit
  6. 22 Jun, 2018 1 commit
  7. 29 May, 2018 2 commits
  8. 25 May, 2018 1 commit
  9. 24 May, 2018 1 commit
  10. 23 May, 2018 1 commit
  11. 08 Jan, 2018 1 commit
  12. 03 Nov, 2017 1 commit
  13. 21 Oct, 2017 2 commits
  14. 28 Mar, 2014 1 commit
    • Albert Astals Cid's avatar
      Fix error reported by ASAN in 590.asan.0.7288.pdf · 49b4eb68
      Albert Astals Cid authored
      ==31898== ERROR: AddressSanitizer: heap-use-after-free on address 0x60ae0007432c at pc 0x7f03483026aa bp 0x7fff6ec0c820 sp 0x7fff6ec0c818
      READ of size 4 at 0x60ae0007432c thread T0
          #0 0x7f03483026a9 in SplashFTFont::getGlyphPath(int) /home/tsdgeos/devel/poppler/splash/SplashFTFont.cc:414
          #1 0x7f034829f681 in SplashOutputDev::drawChar(GfxState*, double, double, double, double, double, double, unsigned int, int, unsigned int*, int) /home/tsdgeos/devel/poppler/poppler/SplashOutputDev.cc:2239
          #2 0x7f0348100599 in Gfx::doShowText(GooString*) /home/tsdgeos/devel/poppler/poppler/Gfx.cc:4054
          #3 0x7f03480fddb0 in Gfx::opShowSpaceText(Object*, int) /home/tsdgeos/devel/poppler/poppler/Gfx.cc:3886
          #4 0x7f03480dc33a in Gfx::execOp(Object*, Object*, int) /home/tsdgeos/devel/poppler/poppler/Gfx.cc:903
          #5 0x7f03480db50f in Gfx::go(bool) /home/tsdgeos/devel/poppler/poppler/Gfx.cc:762
          #6 0x7f03480db163 in Gfx::display(Object*, bool) /home/tsdgeos/devel/poppler/poppler/Gfx.cc:728
          #7 0x7f03481bddd1 in Page::displaySlice(OutputDev*, double, double, int, bool, bool, int, int, int, int, bool, bool (*)(void*), void*, bool (*)(Annot*, void*), void*, bool) /home/tsdgeos/devel/poppler/poppler/Page.cc:585
          #8 0x7f03481c52fd in PDFDoc::displayPageSlice(OutputDev*, int, double, double, int, bool, bool, bool, int, int, int, int, bool (*)(void*), void*, bool (*)(Annot*, void*), void*, bool) /home/tsdgeos/devel/poppler/poppler/PDFDoc.cc:503
          #9 0x40311e in savePageSlice(PDFDoc*, SplashOutputDev*, int, int, int, int, int, double, double, char*) /home/tsdgeos/devel/poppler/utils/pdftoppm.cc:222
          #10 0x404416 in main /home/tsdgeos/devel/poppler/utils/pdftoppm.cc:521
          #11 0x7f03477e5ec4 (/lib/x86_64-linux-gnu/libc.so.6+0x21ec4)
          #12 0x401d58 in _start (/home/tsdgeos/devel/poppler/build-debug/utils/pdftoppm+0x401d58)
      49b4eb68
  15. 27 Mar, 2014 1 commit
    • Albert Astals Cid's avatar
      Fix error reported by ASAN in 2279.asan.0.1904.pdf · 89a64b50
      Albert Astals Cid authored
      ==20507== ERROR: AddressSanitizer: heap-buffer-overflow on address 0x60420000ff04 at pc 0x7fa1492e8012 bp 0x7fff8406d900 sp 0x7fff8406d8f8
      READ of size 4 at 0x60420000ff04 thread T0
          #0 0x7fa1492e8011 in SplashFTFont::makeGlyph(int, int, int, SplashGlyphBitmap*, int, int, SplashClip*, SplashClipResult*) /home/tsdgeos/devel/poppler/splash/SplashFTFont.cc:284
          #1 0x7fa1492eda32 in SplashFont::getGlyph(int, int, int, SplashGlyphBitmap*, int, int, SplashClip*, SplashClipResult*) /home/tsdgeos/devel/poppler/splash/SplashFont.cc:168
          #2 0x7fa1492e7c69 in SplashFTFont::getGlyph(int, int, int, SplashGlyphBitmap*, int, int, SplashClip*, SplashClipResult*) /home/tsdgeos/devel/poppler/splash/SplashFTFont.cc:233
          #3 0x7fa1492b3368 in Splash::fillChar(double, double, int, SplashFont*) /home/tsdgeos/devel/poppler/splash/Splash.cc:2714
          #4 0x7fa149286a20 in SplashOutputDev::drawChar(GfxState*, double, double, double, double, double, double, unsigned int, int, unsigned int*, int) /home/tsdgeos/devel/poppler/poppler/SplashOutputDev.cc:2270
          #5 0x7fa1490e7599 in Gfx::doShowText(GooString*) /home/tsdgeos/devel/poppler/poppler/Gfx.cc:4054
          #6 0x7fa1490e4db0 in Gfx::opShowSpaceText(Object*, int) /home/tsdgeos/devel/poppler/poppler/Gfx.cc:3886
          #7 0x7fa1490c333a in Gfx::execOp(Object*, Object*, int) /home/tsdgeos/devel/poppler/poppler/Gfx.cc:903
          #8 0x7fa1490c250f in Gfx::go(bool) /home/tsdgeos/devel/poppler/poppler/Gfx.cc:762
          #9 0x7fa1490c2163 in Gfx::display(Object*, bool) /home/tsdgeos/devel/poppler/poppler/Gfx.cc:728
          #10 0x7fa1491a4dd1 in Page::displaySlice(OutputDev*, double, double, int, bool, bool, int, int, int, int, bool, bool (*)(void*), void*, bool (*)(Annot*, void*), void*, bool) /home/tsdgeos/devel/poppler/poppler/Page.cc:585
          #11 0x7fa1491ac2fd in PDFDoc::displayPageSlice(OutputDev*, int, double, double, int, bool, bool, bool, int, int, int, int, bool (*)(void*), void*, bool (*)(Annot*, void*), void*, bool) /home/tsdgeos/devel/poppler/poppler/PDFDoc.cc:503
          #12 0x40311e in savePageSlice(PDFDoc*, SplashOutputDev*, int, int, int, int, int, double, double, char*) /home/tsdgeos/devel/poppler/utils/pdftoppm.cc:222
          #13 0x404416 in main /home/tsdgeos/devel/poppler/utils/pdftoppm.cc:521
          #14 0x7fa1487ccec4 (/lib/x86_64-linux-gnu/libc.so.6+0x21ec4)
          #15 0x401d58 in _start (/home/tsdgeos/devel/poppler/build-debug/utils/pdftoppm+0x401d58)
      89a64b50
  16. 13 Nov, 2012 1 commit
  17. 03 Oct, 2012 1 commit
  18. 06 Feb, 2012 1 commit
  19. 10 Jan, 2012 1 commit
  20. 27 Oct, 2011 1 commit
  21. 01 Sep, 2011 2 commits
  22. 30 Aug, 2011 1 commit
  23. 25 Feb, 2011 1 commit
  24. 21 Jan, 2011 1 commit
  25. 11 Dec, 2010 1 commit
  26. 16 Oct, 2010 1 commit
  27. 17 Feb, 2010 1 commit
  28. 05 Oct, 2009 1 commit
  29. 20 May, 2009 1 commit
  30. 07 May, 2009 1 commit
  31. 10 Apr, 2009 1 commit
  32. 30 Mar, 2009 1 commit
    • Albert Astals Cid's avatar
      Fix clip test for fonts · b0b9798c
      Albert Astals Cid authored
      Fixes bug 20950
      I really don't remember why i put that -1 maybe i got mislead by SplashClip::testRect
      having a +1, but the idea of the +1 is correct because it's ints vs floats
      b0b9798c
  33. 25 Mar, 2009 1 commit
  34. 20 Sep, 2008 1 commit
  35. 24 Aug, 2008 1 commit
    • Albert Astals Cid's avatar
      Add more correct copyright statements on fofi, goo, poppler and util... · 47f54ad4
      Albert Astals Cid authored
      Add more correct copyright statements on fofi, goo, poppler and util directories to be more compliant with GPL that requires such modification statements to be present. Meanwhile i did that, i did qt and qt4 dirs too, glib is missing if someone wants to fix it, but it's not crucial as it's not a fork of some other GPL software
      47f54ad4
  36. 29 Jan, 2008 1 commit
  37. 22 Oct, 2007 1 commit
    • Albert Astals Cid's avatar
      Splash rework, check if font is inside clip area before rendering it to a... · 2a333e5a
      Albert Astals Cid authored
      Splash rework, check if font is inside clip area before rendering it to a temporary bitmap. Fixes KDE bug 150693
      
      This change is not trivial. What i did is:
      It is getGlyph the one that does the intersection between clip area and rendering area of the font instead fillGlyph2
      That means some clipRes = state->clip->testRect but we win more robustness against broken pdf that specify HUGE fonts
      2a333e5a