1. 17 Apr, 2019 2 commits
  2. 08 Mar, 2019 1 commit
    • Paul Kocialkowski's avatar
      glamor: Propagate FBO allocation failure for picture to texture upload · c98c7709
      Paul Kocialkowski authored
      When uploading a picture to a texture, glamor_upload_picture_to_texture
      calls glamor_pixmap_ensure_fbo to ensure that there is backing FBO.
      The FBO will be allocated if the picture's drawable pixmap does not have
      one already, which can fail when there is no GL memory left.
      
      glamor_upload_picture_to_texture checks that the call succeeded and will
      enter the failure path if it did not. However, unlike many other
      functions in glamor, this one has ret set to TRUE initially, so it needs
      to be set to FALSE when a failure happens.
      
      Otherwise, the error is not propagated and the failure path return TRUE.
      This leads to a fault when trying to access the FBO pointer later on.
      Signed-off-by: Paul Kocialkowski's avatarPaul Kocialkowski <paul.kocialkowski@bootlin.com>
      c98c7709
  3. 10 Mar, 2016 11 commits
  4. 26 Jan, 2016 1 commit
  5. 20 Jan, 2016 1 commit
  6. 10 Nov, 2015 1 commit
  7. 30 Sep, 2015 1 commit
  8. 10 Jul, 2015 4 commits
  9. 24 Mar, 2015 2 commits
  10. 12 Nov, 2014 1 commit
  11. 15 Jun, 2014 1 commit
    • Keith Packard's avatar
      glamor: Replace fallback preparation code · 15e4d14d
      Keith Packard authored
      These offer a simpler and more efficient means for temporarily
      transitioning to CPU-accessible memory for fallback implementations.
      
      v2: Do not attempt fallbacks with GLAMOR_DRM_ONLY pixmaps
      
          glamor cannot transfer pixels for GLAMOR_DRM_ONLY pixmaps using
          glReadPixels and glTexSubImage2D, and so there's no way to perform
          fallback operations with these pixmaps.
      
      v3: Clear ->pbo field when deleting the PBO.  Otherwise, we'd reuse
          the old name next time we fall back on the pixmap, which would
          potentially conflict with some other pixmap that genned a new
          name, or just do a lazy allocation of the name (compat GL context,
          like we currently use) or error out (core GL context, like we hope
          to use some day).  Also, style fixes.  Changes by anholt, acked by
          keithp.
      Signed-off-by: Keith Packard's avatarKeith Packard <keithp@keithp.com>
      Reviewed-by: Eric Anholt's avatarEric Anholt <eric@anholt.net>
      15e4d14d
  12. 17 Mar, 2014 1 commit
  13. 15 Feb, 2014 1 commit
  14. 27 Jan, 2014 2 commits
  15. 18 Dec, 2013 10 commits