nir/lower_clip: Fix incorrect driver loc for clipdist outputs

Somehow adjusting maxloc based on existing outputs got lost, resulting
in the clipdist varying clobbering the position varying.  Causing a
shader that had no position output in freedreno/ir3, which triggers GPU
hangs in neverball.

Fixes: d0f746b6 ("nir: Save nir_variable pointers in nir_lower_clip_vs rather than locs.")
Signed-off-by: Rob Clark <robdclark@chromium.org>
Reviewed-by: Kristian H. Kristensen <hoegsberg@google.com>
42 jobs for !2954 with wip/neverball-fixes in 47 minutes and 23 seconds (queued for 14 seconds)
detached
Status Job ID Name Coverage
  Container
passed arm_build #1069707
aarch64

00:00:23

passed arm_test #1069708
aarch64

00:00:23

passed lava_arm64 #1069703

00:00:38

passed lava_armhf #1069702

00:00:21

passed x86_build #1069704

00:00:40

passed x86_build_old #1069706

00:00:41

passed x86_test #1069705

00:01:01

 
  Build
passed lava-build:arm64 #1069710

00:04:15

passed lava-build:armhf #1069709

00:04:00

passed meson-arm64 #1069714
aarch64

00:03:24

passed meson-armhf #1069713
aarch64

00:02:22

passed meson-clang #1069715

00:04:26

passed meson-clover #1069718

00:03:57

passed meson-clover-old-llvm #1069719

00:05:07

passed meson-i386 #1069721

00:02:41

passed meson-main #1069712

00:05:45

passed meson-mingw32-x86_64 #1069722

00:04:17

passed meson-testing #1069711

00:04:48

passed meson-vulkan #1069720

00:06:45

passed scons #1069723

00:04:51

passed scons-old-llvm #1069724

00:02:53

passed scons-swr #1069716

00:05:25

passed scons-win64 #1069717

00:05:38

 
  Test
passed arm64_a306_gles2 #1069743
db410c

00:05:33

passed arm64_a630_gles2 #1069740
mesa-cheza

00:01:35

passed arm64_a630_gles3 #1069742
mesa-cheza

00:05:57

passed arm64_a630_gles31 #1069741
mesa-cheza

00:04:13

passed panfrost-t720-test:arm64 #1069725
lava-sun50i-h6-pine-h64

00:07:52

passed panfrost-t760-test:armhf #1069726
lava-rk3288-veyron-jaq

00:05:16

passed panfrost-t820-test:arm64 #1069728
lava-meson-gxm-khadas-vim2

00:09:09

passed panfrost-t860-test:arm64 #1069727
lava-rk3399-gru-kevin

00:06:13

passed piglit-glslparser #1069730

00:04:15

passed piglit-quick_gl #1069729

00:09:19

passed piglit-quick_shader #1069731

00:04:53

passed test-llvmpipe-gles2 #1069732

00:05:51

passed test-softpipe-gles2 #1069733

00:01:27

passed test-softpipe-gles31 1/4 #1069736

00:02:56

passed test-softpipe-gles3 1/2 #1069734

00:05:15

passed test-softpipe-gles31 2/4 #1069737

00:04:16

passed test-softpipe-gles31 3/4 #1069738

00:05:11

passed test-softpipe-gles31 4/4 #1069739

00:05:09

passed test-softpipe-gles3 2/2 #1069735

00:07:52