Fix whitespace and error behaviour for _dbus_command_from_pid()

Closes #222

See merge request !28

Reviewed-by: pwithnall

Signed-off-by: Simon McVittie <smcv@collabora.com>

If a function returns boolean for success/error, and returns a
DBusError, then it should set the DBusError if and only if it
returns FALSE.

Signed-off-by: Simon McVittie <smcv@collabora.com>

Resolves: #222


Signed-off-by: Simon McVittie <smcv@collabora.com>

In particular this demonstrates that #222

 has been solved.

Signed-off-by: Simon McVittie <smcv@collabora.com>

This is basically the same as get_test_exec() in dbus-spawn-test.c,
but GLib-flavoured.

Signed-off-by: Simon McVittie <smcv@collabora.com>

This is a wrapper for g_test_incomplete(), which works around bugs in
that function prior to GLib 2.57.3. I originally wrote it for librsvg.

Signed-off-by: Simon McVittie <smcv@collabora.com>

It will be used as a long-running subprocess to test
_dbus_command_for_pid().

Signed-off-by: Simon McVittie <smcv@collabora.com>

We might need these to run tests at build-time, so we should build them
whenever either modular or embedded tests are enabled, even if
installed-tests aren't.

We haven't noticed this bug until now because $(installable_helpers)
only contained test-apparmor-activation, which isn't normally needed at
build-time because the AppArmor test can only work when run as root.

Signed-off-by: Simon McVittie <smcv@collabora.com>

Add windows implementation of dbus-run-session helper tool for cmake

See merge request !22

Bug: #135


Signed-off-by: Ralf Habacker <ralf.habacker@freenet.de>
Reviewed-by: Simon McVittie <smcv@collabora.com>

This reverts commit bd6ece89,
which was added without a final review.

cmake: Install dbus-daemon-launch-helper even if tests are disabled

See merge request !9
Reviewed-by: rhabacker

Instead of hard-coding the lib subdirectory of the installation prefix,
use the ${CMAKE_INSTALL_LIBEXECDIR} provided by the GNUInstallDirs
module, which defaults to the libexec subdirectory of the installation
prefix. This is consistent with the Autotools build system, which
installs to ${exec_prefix}/libexec unless modified with --libexecdir.

Signed-off-by: Simon McVittie <smcv@collabora.com>

As suggested by Ralf Habacker on !9

.

Signed-off-by: Simon McVittie <smcv@collabora.com>

This is a long-standing bug, spotted while moving test code into
the test directory.

Signed-off-by: Simon McVittie <smcv@collabora.com>

Cleanup of the cmake definitions of source directories

See merge request !27

Reviewed-by: smcv

Ralf Habacker authored Oct 23, 2018 and Simon McVittie committed Oct 25, 2018

Since the cmake build system is located below the cmake/
subdirectory, references to the source files used such as
../../bus or ${CMAKE_SOURCE_DIR}/../dbus etc. are required.
To standardize and simplify this, a cmake variable is now
defined in each of the listed directories, which contains
the corresponding path.

Take cmake checks from configure.ac

See merge request !18

Bug: !18

Reviewed-by: Simon McVittie <smcv@collabora.com>
Bug: !18

Reviewed-by: Simon McVittie <smcv@collabora.com>
Bug: !18

Reviewed-by: Simon McVittie <smcv@collabora.com>
Bug: !18

Reviewed-by: Simon McVittie <smcv@collabora.com>
Bug: dbus/dbus!18

For test case execution, CheckCSourceCompiles is now used instead
of try_compile and the determination of DBUS_VA_AS_ARRAY is
performed with a separate test instead of evaluating the result
of HAVE_VA_COPY and HAVE___VA_COPY.

The tests are performed for all supported compilers. Since older
MSVC compilers (< 2013) do not support va_copy(), the macro
_DBUS_VA_ASSIGN(a1,a2) with the implementation { a1 = a2; } is used
as a fallback.

Reviewed-by: Simon McVittie <smcv@collabora.com>
Bug: dbus/dbus!18

Reviewed-by: Simon McVittie <smcv@collabora.com>
Bug: dbus/dbus!18

Reviewed-by: Simon McVittie <smcv@collabora.com>
Bug: dbus/dbus!18

dbus-daemon test: Allow much longer for pending fd timeout

Reviewed-by: rhabacker
See merge request dbus/dbus!26

The timeout we're using here is 0.5s (500ms), but the actual time taken
is unbounded, because the OS scheduler might not schedule our process
for an arbitrary length of time after we become runnable.

We previously allowed up to 1 second, but in the CI jobs for dbus!9
and dbus!18 we've seen this take up to 3.4 seconds (presumably
because other tests, or other jobs running on the same shared
infrastructure, starved this process). Allow up to 10 seconds to guard
against spurious failures.

The timeout used in the production system.conf is 150 seconds (2½
minutes), and we're only using the shorter 500ms timeout here to make
the test complete more quickly, so ±10 seconds is relatively
insignificant: the main thing is that it's finite.

Signed-off-by: Simon McVittie <smcv@collabora.com>

build: Never use poll() on Darwin family (macOS, etc.) or Interix

Closes: #232
Reviewed-by: @rhabacker
See merge request dbus/dbus!19

Doing a runtime check in configure.ac (AC_RUN_IFELSE) has several
disadvantages:

* It doesn't work when cross-compiling. For example, if we build macOS
  binaries on a Linux system, we'd assume that poll() works, but in
  fact it won't.

* It checks the build system capabilities, but that is not necessarily
  appropriate if (for example) a macOS 10.10 user builds binaries that
  could be used by macOS 10.12 or macOS 10.9 users.

* It checks for one specific failure mode, but macOS seems to have a
  history of various implementation issues in poll().

* If we want it to work in CMake, we have to duplicate it in the CMake
  build system.

None of these is a showstopper on its own, but the combination of all
of them makes the current approach to avoiding the broken poll() on
macOS look unreliable. libcurl, a widely-portable library making
extensive use of sockets, specifically doesn't use poll() on Darwin
(macOS, iOS, etc.) or on Interix; let's follow their example here.

See also https://bugzilla.gnome.org/show_bug.cgi?id=302672 and
https://daniel.haxx.se/blog/2016/10/11/poll-on-mac-10-12-is-broken/


for some relevant history.

Signed-off-by: Simon McVittie <smcv@collabora.com>
Resolves: dbus/dbus#232

Signed-off-by: Simon McVittie <smcv@collabora.com>

Ralf Habacker authored Oct 22, 2018 and Simon McVittie committed Oct 22, 2018

CMake expects a semicolon-separated list of headers, not a
space-separated list. In particular, this meant we failed to detect
getpwnam_r() on Linux, and fell back to getpwnam().

Reviewed-by: Simon McVittie <smcv@collabora.com>

Signed-off-by: Simon McVittie <smcv@collabora.com>

The README change reuses text from CONTRIBUTING.md.

Signed-off-by: Simon McVittie <smcv@collabora.com>

Signed-off-by: Simon McVittie <smcv@collabora.com>

Bug: dbus/dbus#117


Reviewed-by: Simon McVittie <smcv@collabora.com>

Bug: dbus/dbus#117


Reviewed-by: Simon McVittie <smcv@collabora.com>