1. 10 Nov, 2019 1 commit
    • Raul Fernandes's avatar
      Put the switch statement outside of loop · c21cee1c
      Raul Fernandes authored
      The switch statement is inside of the loop but it always resolves to same case.
      Put it outside to optimize the code.
      When the case is of one specific color, the other colors is always zero and makes no changes to final result.
      So, remove the unnecessary code.
      c21cee1c
  2. 08 Nov, 2019 4 commits
  3. 07 Nov, 2019 1 commit
    • Dor Askayo's avatar
      xwayland: clear pixmaps after creation in rootless mode · 0e9a0c20
      Dor Askayo authored
      When a pixmap is created with a backing FBO, the FBO should be cleared
      to avoid rendering uninitialized memory. This could happen when the
      pixmap is rendered without being filled in its entirety.
      
      One example is when a top-level window without a background is
      resized. The pixmap would be reallocated to prepare for more pixels,
      but uninitialized memory would be rendered in the resize offset until
      the client sends a frame that fills these additional pixels.
      
      Another example is when a new top-level window is created without a
      background. Uninitialized memory would be rendered after the pixmap is
      allocated and before the client sends its first frame.
      
      This issue is only apparent in OpenGL implementations that don't zero
      the VRAM of allocated buffers by default, such as RadeonSI.
      Signed-off-by: Dor Askayo's avatarDor Askayo <dor.askayo@gmail.com>
      Closes: #636Reviewed-by: Michel Dänzer's avatarMichel Dänzer <mdaenzer@redhat.com>
      0e9a0c20
  4. 06 Nov, 2019 1 commit
    • Olivier Fourdan's avatar
      xwayland: make context current to check GL version · a506b4ec
      Olivier Fourdan authored
      `glGetString(GL_VERSION)` will return NULL without a current context.
      
      Commit dabc7d8b (“xwayland: Fall back to GLES2 if we don't get at least
      GL 2.1 in glamor”) would check the context is created, but it is made
      current just after, so the call to `epoxy_gl_version()` would return 0,
      hence defeating the version check.
      
      Make the context current prior to call `epoxy_gl_version()`.
      
      Fixes: dabc7d8b - xwayland: Fall back to GLES2 if we don't get at least
                        GL 2.1 in glamor
      Closes: #932
      !324Signed-off-by: default avatarOlivier Fourdan <ofourdan@redhat.com>
      a506b4ec
  5. 05 Nov, 2019 1 commit
  6. 04 Nov, 2019 1 commit
    • Hans de Goede's avatar
      glamor/xwayland: Define EGL_NO_X11 · 741bd734
      Hans de Goede authored
      Define EGL_NO_X11 everywhere were we also define MESA_EGL_NO_X11_HEADERS,
      EGL_NO_X11 is the MESA_EGL_NO_X11_HEADERS equivalent for the egl headers
      shipped with libglvnd.
      
      This fixes the xserver not building with the libglvnd-1.2.0 headers:
      
      In file included from /usr/include/EGL/eglplatform.h:128,
                       from /usr/include/epoxy/egl_generated.h:11,
                       from /usr/include/epoxy/egl.h:46,
                       from glamor_priv.h:43,
                       from glamor_composite_glyphs.c:25:
      /usr/include/X11/Xlib.h:222:2: error: conflicting types for 'GC'
        222 | *GC;
            |  ^~
      In file included from glamor.h:34,
                       from glamor_priv.h:32,
                       from glamor_composite_glyphs.c:25:
      ../include/gcstruct.h:282:3: note: previous declaration of 'GC' was here
        282 | } GC;
            |   ^~
      Signed-off-by: default avatarHans de Goede <hdegoede@redhat.com>
      741bd734
  7. 30 Oct, 2019 18 commits
  8. 29 Oct, 2019 2 commits
  9. 26 Oct, 2019 1 commit
  10. 23 Oct, 2019 1 commit
  11. 16 Oct, 2019 1 commit
  12. 15 Oct, 2019 8 commits