Added debug messages, fixed parser ...

Vasily Khoruzhick authored Nov 24, 2019 and Andreas Baierl committed Nov 25, 2019

Since we're using a separate per-draw BO for GP outputs we don't
need suballocator anymore.

Signed-off-by: Vasily Khoruzhick <anarsoul@gmail.com>

Vasily Khoruzhick authored Nov 24, 2019 and Andreas Baierl committed Nov 25, 2019

Varyings, gl_Position and gl_PointSize are all GP outputs, so we
can use a single BO for them all. Also that allows us to get rid
of suballocator.

Signed-off-by: Vasily Khoruzhick <anarsoul@gmail.com>

Vasily Khoruzhick authored Nov 24, 2019 and Andreas Baierl committed Nov 25, 2019

Signed-off-by: Vasily Khoruzhick <anarsoul@gmail.com>

Erico Nunes authored Nov 09, 2019 and Andreas Baierl committed Nov 25, 2019

The Mali400 only supports draws with up to 64k vertices per command.
To handle this, break the draw_vbo call into multiple commands.
Indexed drawing is left to a separate code path.
This implementation was ported from vc4_draw_vbo.

Signed-off-by: Erico Nunes <nunes.erico@gmail.com>

Erico Nunes authored Nov 12, 2019 and Andreas Baierl committed Nov 25, 2019

This can also be useful for other hardware which has similar limitations
on vertex count per single draw.
The Mali400 has a similar limitation and can reuse this.

Signed-off-by: Erico Nunes <nunes.erico@gmail.com>

Erico Nunes authored Nov 09, 2019 and Andreas Baierl committed Nov 25, 2019

As of this commit this is just a refactor in preparation to enable
support for more than 64k vertices.
To support splitting the draw_vbo call, indices shouldn't be re-uploaded
every time.

Signed-off-by: Erico Nunes <nunes.erico@gmail.com>

Erico Nunes authored Oct 24, 2019 and Andreas Baierl committed Nov 25, 2019

The current strategy using the suballocator with fixed size doesn't
scale and causes some programs with large number of vertices (like some
glmark2 scenes) to crash.
Change it to dynamically allocate a separate bo to accomodate for
arbitrary number of vertices.

Signed-off-by: Erico Nunes <nunes.erico@gmail.com>

This happens when mesa is built with only swrast. The default
driver being kmsro and the default driconf file being v3d,
it's NULL and then strdup crashes.

This fixes a crash with piglit spec/egl_mesa_query_driver/conformance.

Signed-off-by: Samuel Pitoiset <samuel.pitoiset@gmail.com>
Reviewed-by: Michel Dänzer <mdaenzer@redhat.com>
Reviewed-by: Kristian H. Kristensen <hoegsberg@google.com>

Alyssa Rosenzweig authored Nov 20, 2019 and Tomeu Vizoso committed Nov 21, 2019

Enough trial and error ... just think even *more* Midgard about where
this field might be!

Signed-off-by: Alyssa Rosenzweig <alyssa.rosenzweig@collabora.com>

This should fix android build issues while still allowing scons to
build the standalone compiler.

Closes: mesa/mesa#2129



Reviewed-by: Mark Janes <mark.a.janes@intel.com>

also make 8 and 16 compoments invalid. We will enable that later again
when we actually support it.

v2: fix validation of nir_intrinsic_instr::num_components
    correct validation of instr->num_components

Signed-off-by: Karol Herbst <kherbst@redhat.com>
Reviewed-by: Jason Ekstrand <jason@jlekstrand.net>

This reverts commit db0c89d4.

Gitlab: mesa/mesa#2128
Acked-by: Marek Olšák <maraeo@gmail.com>

This reverts commit 3a8d6868.

Acked-by: Marek Olšák <maraeo@gmail.com>

Arno Messiaen authored Nov 02, 2019 and Vasily Khoruzhick committed Nov 20, 2019

Signed-off-by: Arno Messiaen <arnomessiaen@gmail.com>
Reviewed-by: Erico Nunes <nunes.erico@gmail.com>

This reverts commit 52c7df16.  The pass,
while clearly useful for some shaders, has at least three bugs that I
was able to find fairly quickly:

 1. It doesn't work for type-converting MOVs because f > 0 is not the
    same as f2i(f) > 0

 2. CSEL is a 3src instruction and only supports one source type; it
    doesn't take this into account and tries to create instructions
    which do a F compare and a D select.  This is especially nasty to
    debug because you don't see that in the dumped assembly because we
    don't properly assert that types are the same in codegen.

 3. While you can handle 2, in theory, by reinterpreting types, you
    can't do that in the presence of source modifiers.  This pass
    doesn't even attempt to detect that.

Those are just the ones I found with the one almost trival shader I was
debugging.  There very likely may be more and.  Best thing to do for now
is just shut it off until someone has the time to figure out how to do
this properly and write tests to ensure it's correct.

Fixes: 3cb085e6 "i965/fs: Merge CMP and SEL into CSEL on Gen8+"
Reviewed-by: Brian Paul <brianp@vmware.com>

This patch also allows to enable VK_AMD_shader_ballot on SI.

Reviewed-by: Samuel Pitoiset <samuel.pitoiset@gmail.com>

The idea of this implementation is taken from the ROCm Device Libs:
https://github.com/RadeonOpenCompute/ROCm-Device-Libs/blob/master/ockl/src/wfredscan.cl



Reviewed-by: Samuel Pitoiset <samuel.pitoiset@gmail.com>

Andreas Baierl authored Nov 18, 2019 and Vasily Khoruzhick committed Nov 20, 2019

Reviewed-by: Vasily Khoruzhick <anarsoul@gmail.com>
Signed-off-by: Andreas Baierl <ichgeh@imkreisrum.de>

Andreas Baierl authored Nov 18, 2019 and Vasily Khoruzhick committed Nov 20, 2019

Reviewed-by: Vasily Khoruzhick <anarsoul@gmail.com>
Signed-off-by: Andreas Baierl <ichgeh@imkreisrum.de>

Yevhenii Kolesnikov authored Nov 07, 2019 and Dylan Baker committed Nov 20, 2019

Do not link libgallium_nine with libgalliumvl_stub if it's already
linked with libgalliumvl. Linking with stub leads to "duplicate
symbol" errors.

Fixes: 6b4c7047
       ("meson: build gallium nine state_tracker")
Closes: mesa/mesa#2040



Signed-off-by: Yevhenii Kolesnikov <yevhenii.kolesnikov@globallogic.com>
Reviewed-by: Dylan Baker <dylan@pnwbakers.com>

Signed-off-by: Rhys Perry <pendingchaos02@gmail.com>
Reviewed-by: Connor Abbott <cwabbott0@gmail.com>

This will be useful as a deterministic identifier/index for the variable.

v2: fix comment style

Signed-off-by: Rhys Perry <pendingchaos02@gmail.com>
Reviewed-by: Connor Abbott <cwabbott0@gmail.com> (v1)

Doesn't shrink it (at least, on x86-64) and leaves space for more members.

Signed-off-by: Rhys Perry <pendingchaos02@gmail.com>
Reviewed-by: Connor Abbott <cwabbott0@gmail.com>

[skip ci]

Signed-off-by: Samuel Pitoiset <samuel.pitoiset@gmail.com>
Reviewed-by: Bas Nieuwenhuizen <bas@basnieuwenhuizen.nl>

Hyunjun Ko authored Oct 24, 2019 and Neil Roberts committed Nov 20, 2019

Reviewed-by: Rob Clark <robdclark@gmail.com>

Hyunjun Ko authored Aug 30, 2019 and Neil Roberts committed Nov 20, 2019

Reviewed-by: Rob Clark <robdclark@gmail.com>

Hyunjun Ko authored Jun 21, 2019 and Neil Roberts committed Nov 20, 2019

Fixes: cea39af2 ("freedreno/ir3: Generalize ir3_shader_disasm()")

Reviewed-by: Rob Clark <robdclark@gmail.com>

Reviewed-by: Rob Clark <robdclark@gmail.com>

Hyunjun Ko authored Oct 23, 2019 and Neil Roberts committed Nov 20, 2019

Reviewed-by: Rob Clark <robdclark@gmail.com>

Reviewed-by: Rob Clark <robdclark@gmail.com>

Reviewed-by: Rob Clark <robdclark@gmail.com>

v2. [Hyunjun Ko (zzoon@igalia.com)]
Avoid using too much open code like "instr->regs[n]->flags |= FOO"

v3. [Hyunjun Ko (zzoon@igalia.com)]
Remove redundant code for both 16b and 32b operations.

Reviewed-by: Rob Clark <robdclark@gmail.com>

Hyunjun Ko authored Sep 27, 2019 and Neil Roberts committed Nov 20, 2019

Prep-work for the corresponding patch.

Reviewed-by: Rob Clark <robdclark@gmail.com>

Reviewed-by: Rob Clark <robdclark@gmail.com>
Acked-by: Alyssa Rosenzweig <alyssa.rosenzweig@collabora.com>

Adds nir_type_bool8 as well as 8-bit versions of all the bool
opcodes.

Reviewed-by: Rob Clark <robdclark@gmail.com>
Acked-by: Alyssa Rosenzweig <alyssa.rosenzweig@collabora.com>