samba-data-tool option refuses to take its optional argument
I noticed this while debugging a problem on my system.
The --samba-data-tool
option should take a required argument, but instead it complains:
[root@scooter ghartzell]# adcli update --add-samba-data --samba-data-tool=/bin/net
update: option '--samba-data-tool' doesn't allow an argument
usage: adcli update
-D, --domain=<...> active directory domain name
-S, --domain-controller=<...>
domain controller to connect to
-H, --host-fqdn=<...> override the fully qualified domain name of the
local machine
-K, --host-keytab=<...> filename for the host kerberos keytab
-N, --computer-name=<...> override the netbios short name of the local
machine
-C, --login-ccache=<...> kerberos credential cache file which contains
ticket to used to connect to the domain
-V, --service-name=<...> additional service name for a kerberos
service principal to be created on the account
--os-name=<...> the computer operating system name
--os-version=<...> the computer operating system version
--os-service-pack=<...> the computer operating system service pack
--user-principal=<...> add an authentication principal to the account
--computer-password-lifetime=<...>
lifetime of the host accounts password in days
--trusted-for-delegation=<...>
set/unset the TRUSTED_FOR_DELEGATION flag
in the userAccountControl attribute
--add-service-principal=<...>
add the given service principal to the account
--remove-service-principal=<...>
remove the given service principal from the account
--show-details show information about joining the domain after
a successful join
--show-password show computer account password after after a
successful join
--add-samba-data add domain SID and computer account password
to the Samba specific configuration database
--samba-data-tool Absolute path to the tool used for add-samba-data
-v, --verbose show verbose progress and failure messages
The problem is almost certainly right here in computer.c, where instead of no_argument
is should read required_argument
.
I'm not set up to build adcli. I could PR the change but have no simple way to test it....
Edited by George Hartzell