Port to HEIMDAL
Submitted by Mikhail T.
Assigned to Stef Walter
Description
Created attachment 124563 Port outside of Linux -- and allow both MIT and Heimdal kerberos implementations to work
Attached are patches I had to implement to port adcli to FreeBSD. A few hunks deal with general porting (some headers must be explicitly #include-ed on BSD, which are implicitly loaded on Linux), but the vast majority is for Heimdal compatibility.
Tested on FreeBSD-10.3 using both MIT Kerberos libraries and Heimdal GSSAPI, that comes with the OS. `make check' passes too, but I do not know, how comprehensive that is:
test-seq' is up to date.
test-util' is up to date.
test-ldap' is up to date.
test-attrs' is up to date.
make check-TESTS
PASS: test-seq
PASS: test-util
PASS: test-ldap
PASS: test-attrs
adcli-0.8.1 % make check
Making check in build
Making check in library
make test-seq test-util test-ldap test-attrs
Testsuite summary for adcli 0.8.1
TOTAL: 4
PASS: 4
SKIP: 0
XFAIL: 0
FAIL: 0
XPASS: 0
ERROR: 0
============================================================================ Making check in tools Making check in doc mkdir -p ./html && cp ./static/* ./html/ true html -m ./gtk-doc.xsl -o ./html --searchpath .:. ./adcli-docs.xml
The very first hunk patches configure, which is included in the source tarball (0.8.1). You'll probably patch configure.ac instead.
The rest should be applicable straight. I had to disable the use/creation of custom krb5.conf in Heimdal case -- the Heimdal does not support includedir and include directives. Fortunately, it seems like it is not necessary anyway...
Detecting Heimdal (and adding -DHEIMDAL to CFLAGS) would be nice too, but I'm not well-versed with configure/libtool et. al.
I'd also like to request, that the prebuilt manual-page (adcli.8) be bundled with the release and installed regardless of --disable-doc. (man-pages are special.) Building it from the XML-source requires xsltproc, which may be too heavy a dependency for some. A minor point...
Patch 124563, "Port outside of Linux -- and allow both MIT and Heimdal kerberos implementations to work":
patch-adcli-combined