Commit 5b4a7ec8 authored by Adam Jackson's avatar Adam Jackson 🎧
Browse files

r600/sb: Fix an &/&& mistake



gcc says:

    sb/sb_sched.cpp: In member function 'bool r600_sb::alu_group_tracker::try_reserve(r600_sb::alu_node*)':
    sb/sb_sched.cpp:492:7: warning: suggest parentheses around operand of '!' or change '&' to '&&' or '!' to '~' [-Wparentheses]
      if (!trans & fbs)

It happens to be harmless; if fbs is ever non-zero, it will be VEC_210,
which is 5, so (!trans & 5) == 1 and the branch works as expected.  But
logical AND is clearly what was meant.

Reviewed-by: default avatarAlex Deucher <alexander.deucher@amd.com>
Signed-off-by: Adam Jackson's avatarAdam Jackson <ajax@redhat.com>
parent 545dec5b
...@@ -489,7 +489,7 @@ bool alu_group_tracker::try_reserve(alu_node* n) { ...@@ -489,7 +489,7 @@ bool alu_group_tracker::try_reserve(alu_node* n) {
n->bc.bank_swizzle = 0; n->bc.bank_swizzle = 0;
if (!trans & fbs) if (!trans && fbs)
n->bc.bank_swizzle = VEC_210; n->bc.bank_swizzle = VEC_210;
if (gpr.try_reserve(n)) { if (gpr.try_reserve(n)) {
......
Supports Markdown
0% or .
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment