Revert "mogwai-scheduled: Fix dependency name for systemd"

See merge request !26

This reverts commit ed84c697, and
additionally changes the CI config to install the package providing
`systemd.pc`, which was missing before. `libsystemd-dev` needs to be
kept as a dependency, as `libsystemd.so` is actually used by
the libgsystemservice subproject. The CI build uses libgsystemservice as
a subproject as it’s not available on Debian Unstable at the moment.

The pkg-config name was correct before. Both `libsystemd.pc` and
`systemd.pc` exist, but `systemd.pc` is the one which defines all
systemd’s directory paths and variables. `libsystemd.pc` is just for the
cflags/libs for linking to libsystemd.

Unsure how I managed to get this commit working before.

Signed-off-by: Philip Withnall <pwithnall@endlessos.org>

Signed-off-by: Philip Withnall <pwithnall@endlessos.org>

mogwai-schedule-client: Add support for libsoup-3.0

See merge request !25

Signed-off-by: Philip Withnall <pwithnall@endlessos.org>

Robert McQueen authored May 27, 2022 and Philip Withnall committed Jun 24, 2022

The main change is the removal of the SoupRequest object and using the
soup_session_send_async API directly on the SoupSession instead.

This commit adds support for using libsoup-3.0 instead of libsoup-2.4,
and sets it as the default. libsoup-2.4 can still be used if Mogwai is
configured with `-Dsoup2=true`.

See
https://discourse.gnome.org/t/please-build-against-libsoup-3-by-default/10190
for context.

build: Port to libgsystemservice

Closes #3

See merge request !23

It’s not packaged on Debian Unstable, so needs to be wrapped for the CI.

Signed-off-by: Philip Withnall <pwithnall@endlessos.org>

Signed-off-by: Philip Withnall <pwithnall@endlessos.org>

This introduces no functional changes, but will allow some warnings to
be fixed more easily in the following commit.

Signed-off-by: Philip Withnall <pwithnall@endlessos.org>

Signed-off-by: Philip Withnall <pwithnall@endlessos.org>

libhelper was later fleshed out into libgsystemservice, so port to using
that instead. The functionality is the same, it’s just less code to
maintain in this project.

Signed-off-by: Philip Withnall <pwithnall@endlessos.org>

Fixes: #3

Signed-off-by: Philip Withnall <pwithnall@endlessos.org>

ci: Point to new main branch

See merge request !22

The Python tests run the `mogwai-scheduled` and `mogwai-tariff`
executables internally, so add dependencies to ensure those executables
are built before the tests are run if building using `meson test`.

Signed-off-by: Philip Withnall <pwithnall@endlessos.org>

Signed-off-by: Philip Withnall <pwithnall@endlessos.org>

`master` has been renamed to `main`.

Signed-off-by: Philip Withnall <pwithnall@endlessos.org>

tests: Don’t pass NULL to G_VALUE_LCOPY()

See merge request !21

While it may have previously worked, it’s not how the API was meant to
be used, and a change in GLib 2.66 means that it now causes a critical
warning to be emitted (see
https://gitlab.gnome.org/GNOME/glib/-/merge_requests/1505#note_984868

).

Fix that by using a custom version of `G_VALUE_LCOPY()`.

Signed-off-by: Philip Withnall <pwithnall@endlessos.org>

libmogwai-tariff: Add some debug output to help catch invalid tariffs

See merge request !20

Signed-off-by: Philip Withnall <pwithnall@endlessos.org>

tests: Fix a typo in a comment

See merge request !19

Spotted by running
```
codespell \
    --builtin clear,rare,usage \
    --skip './po/*' --skip './help/*/*.po' --skip './.git/*' --skip './NEWS*' \
    --write-changes .
```

Signed-off-by: Philip Withnall <withnall@endlessm.com>

Improve behaviour with VPNs or multiple connections

See merge request !18

We’re already using Meson features from 0.50.0, and it’s been out a
while, so just bump our dependency officially.

Signed-off-by: Philip Withnall <withnall@endlessm.com>

Signed-off-by: Philip Withnall <withnall@endlessm.com>

Due to the way `can_be_active` is calculated as only being true if all
connections allow downloads, we need to make sure that `allow_downloads`
is only true if all connections allow downloads. Otherwise anything that
bases its UI off `allow_downloads` may say that downloads are allowed,
when actually any scheduled entry will be blocked.

Signed-off-by: Philip Withnall <withnall@endlessm.com>

The tests were assuming that allow-downloads is always FALSE to start,
but future changes might mean that is not true. Get the test to query
the initial value rather than assuming it.

Signed-off-by: Philip Withnall <withnall@endlessm.com>

scheduler: recognise /usr/libexec/eos-updater

See merge request !17

The updater executable, which is service-activated, is [moving][0].
There seems little point in maintaining support for the old path since
the only distro where this is relevant (Endless OS) will update these
two components in lockstep.

[0]: https://github.com/endlessm/eos-updater/pull/256

build: Post-release version bump

See merge request !16

Signed-off-by: Philip Withnall <withnall@endlessm.com>

libmogwai-schedule: Handle NULL NMConnections on activating connections

See merge request !15

If handling an `NMActiveConnection` which is still activating (in state
`NM_ACTIVE_CONNECTION_STATE_ACTIVATING`), its `connection` property will
be `NULL`, rather than pointing to a valid `NMConnection`. Previously,
we were assuming that it would always point to a valid `NMConnection`,
and hence were crashing if not.

Handle that case by monitoring state and property change signals from
`NMActiveConnection` and connecting to the `connection` if it ever
becomes non-`NULL`. This will likely result in multiple connections to
the `NMConnection`, but that should be fine — it’ll only result in some
spurious emissions of `connection-details-changed`, and all the signal
connections should be dropped when the last reference to the
`NMConnection` is dropped. We don’t hold that reference.

This is easy to reproduce by having a VPN set up which takes a few
seconds to connect to. While it’s `ACTIVATING`, `mogwai-scheduled` can
attempt to query the connection information.

Signed-off-by: Philip Withnall <withnall@endlessm.com>

docs: Add some more development/architecture documentation

See merge request !14

Signed-off-by: Philip Withnall <withnall@endlessm.com>

A few minor fixes to the scheduler

See merge request !13

Signed-off-by: Philip Withnall <withnall@endlessm.com>

The return value of a call wasn’t being checked for errors.

Signed-off-by: Philip Withnall <withnall@endlessm.com>

Minor fixes

See merge request !12