1. 30 Mar, 2015 1 commit
  2. 27 Mar, 2015 2 commits
  3. 23 Mar, 2015 1 commit
  4. 19 Mar, 2015 1 commit
  5. 16 Mar, 2015 1 commit
    • Tanu Kaskinen's avatar
      core-util: Make number parsing stricter · c0ab9e6c
      Tanu Kaskinen authored
      pa_atou(), pa_atol() and pa_atod() are stricter than the libc
      counterparts (the PA functions reject strings that have trailing extra
      stuff in them). I have been under the impression that the PA functions
      only accept "obviously valid numbers", that is, I have assumed that
      these would be rejected: " 42" (leading whitespace), "" (empty
      string) and "-18446744073709551615" in case of pa_atou().
      
      I noticed that empty strings are accepted, however, and on closer
      inspection I found that leading whitespace is accepted too, and even
      that pa_atou() thinks that "-18446744073709551615" is the same thing
      as "1"! This patch makes the parsing functions more strict, so that
      they indeed only accept "obviously valid numbers". I decided to also
      disallow leading plus signs, just because I don't like them.
      c0ab9e6c
  6. 12 Mar, 2015 1 commit
    • David Rheinsberg's avatar
      core-util: Fix set_nice() to use private bus connections · b8bcfeb7
      David Rheinsberg authored
      In src/pulsecore/core-util.c:set_nice() we currently use a temporary
      dbus-connection to set the nice-level via rtkit. However, we never
      close that connection. This is fine, as the connection is shared and
      dbus-core will manage it. But no other part of pulseaudio (except
      set_scheduler()) uses the libdbus1 managed connections. Therefore,
      we effectively end up with an unused dbus-connection that is not
      integrated into any main-loop. dbus-daemon will send bus-notifications
      to the connection (as libdbus1 installs matches for those by default
      (it has to!)) until the outgoing queue is full. Thus, we waste several
      KBs (or MBs? I didn't look it up) of memory for a message queue that
      is never dispatched.
      Signed-off-by: David Henningsson's avatarDavid Henningsson <david.henningsson@canonical.com>
      b8bcfeb7
  7. 11 Mar, 2015 3 commits
  8. 26 Feb, 2015 11 commits
  9. 23 Feb, 2015 5 commits
  10. 16 Feb, 2015 3 commits
  11. 12 Feb, 2015 11 commits