Skip to content
GitLab
Projects Groups Snippets
  • /
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
    • Contribute to GitLab
  • Register
  • Sign in
  • pulseaudio pulseaudio
  • Project information
    • Project information
    • Activity
    • Labels
    • Members
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributors
    • Graph
    • Compare
  • Issues 893
    • Issues 893
    • List
    • Boards
    • Service Desk
    • Milestones
  • Merge requests 47
    • Merge requests 47
  • CI/CD
    • CI/CD
    • Pipelines
    • Jobs
    • Schedules
  • Deployments
    • Deployments
    • Environments
    • Releases
  • Packages and registries
    • Packages and registries
    • Container Registry
  • Monitor
    • Monitor
    • Incidents
  • Analytics
    • Analytics
    • Value stream
    • CI/CD
    • Repository
  • Snippets
    • Snippets
  • Activity
  • Graph
  • Create a new issue
  • Jobs
  • Commits
  • Issue Boards
Collapse sidebar

Due to an influx of spam, we have had to impose restrictions on new accounts. Please see this wiki page for instructions on how to get full permissions. Sorry for the inconvenience.

  • PulseAudioPulseAudio
  • pulseaudiopulseaudio
  • Merge requests
  • !742

alsa-ucm: Disable old modifiers when switching profiles of same verb

  • Review changes

  • Download
  • Email patches
  • Plain diff
Merged Alper Nebi Yasak requested to merge alpernebbi/pulseaudio:alsa-ucm-fix-disabling-modifiers into master Aug 19, 2022
  • Overview 0
  • Commits 2
  • Pipelines 3
  • Changes 1

Looks like I forgot to disable modifiers when switching between profiles of the same verb, this is to fix that. I discovered the issue shortly after my code got merged, with a weird UCM config that caused a segfault when switching profiles.

For example, when we have a Speaker-Mic conflict and a PlayTone modifier with a PlaybackPCM value that has SupportedDevice of just Speaker. This gives us two profiles: Speaker (with PlayTone as another mapping), and Mic (without). When switching from Speaker to Mic we get a segfault because we try to disable PlayTone's map->ucm_context.ucm_device which is null.

Assignee
Assign to
Reviewers
Request review from
Time tracking
Source branch: alsa-ucm-fix-disabling-modifiers