Skip to content

GitLab

  • Menu
Projects Groups Snippets
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
    • Contribute to GitLab
  • Sign in / Register
  • pulseaudio pulseaudio
  • Project information
    • Project information
    • Activity
    • Labels
    • Members
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributors
    • Graph
    • Compare
  • Issues 856
    • Issues 856
    • List
    • Boards
    • Service Desk
    • Milestones
  • Merge requests 58
    • Merge requests 58
  • CI/CD
    • CI/CD
    • Pipelines
    • Jobs
    • Schedules
  • Deployments
    • Deployments
    • Environments
    • Releases
  • Monitor
    • Monitor
    • Incidents
  • Packages & Registries
    • Packages & Registries
    • Container Registry
  • Analytics
    • Analytics
    • Value stream
    • CI/CD
    • Repository
  • Snippets
    • Snippets
  • Activity
  • Graph
  • Create a new issue
  • Jobs
  • Commits
  • Issue Boards
Collapse sidebar
  • PulseAudio
  • pulseaudiopulseaudio
  • Merge requests
  • !209

The source project of this merge request has been removed.
Merged
Created Nov 23, 2019 by Hui Wang@jason77wangContributor

Master:change save_sink to preferred_sink [v4]

  • Overview 50
  • Changes 13

In the V4, addressed all comments in the !158 (closed)

=======================================

in the V3, I addressed all Tanu's and Georg's comments: 0002-xxx.patch: remove the pa_subscription_post() in the pa_sink_input_set_preferred_sink()

0003-xxx.patch: Add the check of sink_input->sink->card in the subscribe_callback()

0004-xxx.patch: Initialize the varible old_sink_is_unavailable Add the check of core->default_sink == NULL || core->default_sink->unlink_requested in the pa_sink_move_streams_to_default_sink()

0007-xxx.patch: Move the calling of pa_sink_move_streams_to_default_sink() after the pa_core_update_default_sink() in the pa_sink_unlink() Add shutdown check in the pa_sink_move_streams_to_default_sink() Change the logging message in the pa_sink_move_streams_to_default_sink() Remove the sink and sink_input parts in the module-rescue-streams.c

============================================================

This is based on Tanu's design: https://lists.freedesktop.org/archives/pulseaudio-discuss/2018-October/030531.html

And this is only for sink-input and sink, not for source-output and source.

In the V2, I addressed all comments of V1 and split the big patch into small patches as suggested by Tanu. It will be easy to review in the future.

Assignee
Assign to
Reviewer
Request review from
Time tracking
Source branch: master